Re: [linux-usb-devel] USB-related oops in sysfs with linux v2.6.23-rc3-50-g28e8351

Cornelia Huck
2007-08-15T15:21:18Z

On Wed, 15 Aug 2007 23:54:43 +0900,
Tejun Heo <htejun@gmail.com> wrote:

> Alan Stern wrote:
> > I think we can simply remove the error message. There's no obvious
> > reason why sysfs_remove_bin_file() should complain about attempts to
> > remove a nonexistent file; sysfs_remove_file() doesn't.
> >
> > This patch will get rid of the annoying error messages. It won't do
> > anything about your keyboard's tendency to spontaneously stop working,
> > alas.
>
> Agreed but I think sysfs_remove_bin_file() should relay the return value
> from sysfs_has_and_remove() to the caller.

Three comments:

- Randy made sysfs_remove_bin_file() return void in commit
995982ca79d9262869513948ec7c540f32035491.

- For symmetry reasons, sysfs_remove_file() should then also pass the
return value on.

- I'm not sure who wants to care whether they removed an existing or
non-existing file. But maybe I'm just unimaginative.