From: Ralf Baechle <ralf@linux-mips.org>
To: adaplas@gmail.com, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] Fix warnings in selection.h
Date: Wed, 22 Aug 2007 16:15:18 +0100 [thread overview]
Message-ID: <20070822151518.GA19320@linux-mips.org> (raw)
<linux/selection.h> assumes that struct tty_struct has previously been
included. If not, this pile of warnings will result:
CC [M] drivers/video/console/newport_con.o
In file included from drivers/video/console/newport_con.c:18:
include/linux/selection.h:16: warning: 'struct tty_struct' declared inside param
eter list
include/linux/selection.h:16: warning: its scope is only this definition or decl
aration, which is probably not what you want
include/linux/selection.h:17: warning: 'struct tty_struct' declared inside param
eter list
include/linux/selection.h:20: warning: 'struct tty_struct' declared inside param
eter list
Fixed by adding a forward declaration of struct tty_struct.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
diff --git a/include/linux/selection.h b/include/linux/selection.h
index ed3408b..16184d6 100644
--- a/include/linux/selection.h
+++ b/include/linux/selection.h
@@ -11,6 +11,7 @@
#include <linux/vt_buffer.h>
extern struct vc_data *sel_cons;
+struct tty_struct;
extern void clear_selection(void);
extern int set_selection(const struct tiocl_selection __user *sel, struct tty_struct *tty);
reply other threads:[~2007-08-22 15:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070822151518.GA19320@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox