Re: [PATCH 2/3] dma: override "dma_flags_set_dmaflush" for sn-ia64

Jes Sorensen
2007-08-20T08:26:35Z

akepner@sgi.com wrote:
> Define ARCH_DOES_POSTED_DMA, and override the dma_flags_set_dmaflush
> function. Also define dma_flags_get_direction, dma_flags_get_dmaflush
> to retrieve the direction and "dmaflush attribute" from flags
> passed to the sn_dma_map_* functions.
>

Hi Arthur,

I'm a little concerned about changing the API for the dma_ foo
functions, which are defined cross platform. If you want to change
that, I think it will require updating the documentation explaining
it.

Regarding ARCH_DOES_POSTED_DMA, is that sufficient as a #define or
does it have to be run-time tested? (does it do anything at this
stage). I ask since not all ia64 platforms do posted DMA.

Cheers,
Jes