From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Jakub Jelinek <jakub@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>, Andi Kleen <ak@suse.de>,
Kees Cook <kees@outflux.net>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] i386 and x86_64: randomize brk()
Date: Wed, 22 Aug 2007 15:58:33 -0700 [thread overview]
Message-ID: <20070822155833.5142e588.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0708221750340.7792@jikos.suse.cz>
On Wed, 22 Aug 2007 18:05:01 +0200 (CEST)
Jiri Kosina <jkosina@suse.cz> wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> i386 and x86_64: randomize brk()
>
> This patch randomizes the location of the heap (brk) for i386 and x86_64.
> The range is randomized in the range starting at current brk location up
> to 0x02000000 offset on both architectures. This, together with
> pie-executable-randomization.patch and
> pie-executable-randomization-fix.patch, should make the address space
> randomization on i386 and x86_64 complete (modulo vDSO randomization).
>
> The code is based on execshield code written by Ingo Molnar.
My main concern right now is to try to stabilise the rc3-mm1 mess, so I
think I'll duck this for now.
> +#ifdef ARCH_HAS_RANDOMIZE_BRK
> + if (current->flags & PF_RANDOMIZE)
> + arch_randomize_brk();
> +#endif
erk, please no.
It'd be better to put
static inline void arch_randomize_brk(void)
{
}
into all the other architecture's elf.h, then lose all the ifdefs.
next prev parent reply other threads:[~2007-08-22 23:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-22 16:05 [PATCH] i386 and x86_64: randomize brk() Jiri Kosina
2007-08-22 22:58 ` Andrew Morton [this message]
2007-08-22 23:04 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2007-08-30 13:47 Jiri Kosina
2007-08-30 14:01 ` Mike Frysinger
2007-08-30 14:21 ` Jiri Kosina
2007-08-30 14:26 ` Mike Frysinger
2007-08-30 15:10 ` Jiri Kosina
2007-08-30 15:33 ` Franck Bui-Huu
2007-08-31 1:05 ` Andrew Morton
2007-08-31 11:56 ` Jiri Kosina
2007-09-01 20:19 ` Franck Bui-Huu
2007-09-02 20:28 ` Andrew Morton
2007-09-03 9:34 ` Jiri Kosina
2007-09-03 10:03 ` Jiri Kosina
2007-09-03 17:38 ` Franck Bui-Huu
2007-09-03 20:44 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070822155833.5142e588.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@suse.de \
--cc=arjan@infradead.org \
--cc=hpa@zytor.com \
--cc=jakub@redhat.com \
--cc=jkosina@suse.cz \
--cc=kees@outflux.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox