[2.6.20.17 review 32/58] fs: 9p/conv.c error path fix

Willy Tarreau
2007-08-22T09:00:28Z

[-- Attachment #1: 0032-fs-9p-conv.c-error-path-fix.patch --]
[-- Type: text/plain, Size: 700 bytes --]

When buf_check_overflow() returns != 0 we will hit kfree(ERR_PTR(err))
and it will not be happy about it.

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Willy Tarreau <w@1wt.eu>
---
fs/9p/conv.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/9p/conv.c b/fs/9p/conv.c
index a3ed571..923d75c 100644
--- a/fs/9p/conv.c
+++ b/fs/9p/conv.c
@@ -742,6 +742,7 @@ struct v9fs_fcall *v9fs_create_twrite(u32 fid, u64 offset, u32 count,
if (err) {
kfree(fc);
fc = ERR_PTR(err);
+ goto error;
}

if (buf_check_overflow(bufp)) {
--
1.5.2.5

--