Re: [Git Patch] ACPI: Fix a warning of discarding qualifiers from pointer target type

Alexey Starikovskiy
2007-08-21T15:15:29Z

WANG Cong wrote:
> Fix this warning:
>
> drivers/acpi/ec.c: In function `acpi_ec_ecdt_probe':
> drivers/acpi/ec.c:873: warning: passing arg 1 of `acpi_get_devices' discards qualifiers from pointer target type
>
> (I don't know whether this fix hits the real problem.)
>
It is safe to give acpi_get_devices() const string, as it should not
modify it in any condition.
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
>
>
ACK

Thanks,
Alex
> ---
> drivers/acpi/ec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-2.6.23-rc3-git3/drivers/acpi/ec.c
> ===================================================================
> --- linux-2.6.23-rc3-git3.orig/drivers/acpi/ec.c
> +++ linux-2.6.23-rc3-git3/drivers/acpi/ec.c
> @@ -869,8 +869,8 @@ int __init acpi_ec_ecdt_probe(void)
> boot_ec->handle = ACPI_ROOT_OBJECT;
> } else {
> printk(KERN_DEBUG PREFIX "Look up EC in DSDT\n");
> - status = acpi_get_devices(ec_device_ids[0].id, ec_parse_device,
> - boot_ec, NULL);
> + status = acpi_get_devices((char *)ec_device_ids[0].id,
> + ec_parse_device, boot_ec, NULL);
> if (ACPI_FAILURE(status))
> goto error;
> }
>