Re: [PATCH] - TPM device driver layer (tpm.c|h)

[Greg KH <greg@kroah.com>]

On Thu, Aug 23, 2007 at 10:46:55AM +0200, Richard MUSIL wrote:
> Dear all,
> 
> I am currently writing virtual TPM device driver. This driver exposes
> itself and behaves like regular TPM device (i.e. uses TPM layer which is
> already present in kernel), but instead of talking to hardware it talks
> to user space.

Heh, I like the idea, I can imagine what it could be used for :)

> What I present below is rather quickfix with least impact on other TPM
> parts (drivers). The patch uses device->remove callback (of
> platform_device device) and reroutes this to itself. In this
> callback it eventually calls vendor callback and finally kfrees all
> memory resources allocated on its own.

It looks sane to me, nice fixup.

thanks,

greg k-h