From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765628AbXHWRxz (ORCPT ); Thu, 23 Aug 2007 13:53:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760246AbXHWRxq (ORCPT ); Thu, 23 Aug 2007 13:53:46 -0400 Received: from wa-out-1112.google.com ([209.85.146.183]:42300 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752678AbXHWRxq (ORCPT ); Thu, 23 Aug 2007 13:53:46 -0400 Date: Thu, 23 Aug 2007 10:53:40 -0700 From: Brandon Philips To: Alexey Dobriyan Cc: postfail@hushmail.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH resubmit] /drivers/ata ioremap returncode check Message-ID: <20070823175340.GA6848@ifup.org> References: <20070823023328.19E6CDA82B@mailserver7.hushmail.com> <159327.52462.qm@web44910.mail.sp1.yahoo.com> <20070823053458.GA4418@ifup.org> <20070823174204.GB1818@martell.zuzino.mipt.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070823174204.GB1818@martell.zuzino.mipt.ru> User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 21:42 Thu 23 Aug 2007, Alexey Dobriyan wrote: > On Wed, Aug 22, 2007 at 10:34:58PM -0700, Brandon Philips wrote: > > On 19:47 Wed 22 Aug 2007, Scott Thompson wrote: > > > Patchset against 2.6.23-rc3. corrects missing ioremap return > > > checks, resending after making changes suggested.... > > > > > > Signed-off-by: Scott Thompson hushmail.com> > > > ------------------------------------------------------------ > > > diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c > > > index 4ca7fd6..8dc7c3b 100644 > > > --- a/drivers/ata/pata_ixp4xx_cf.c > > > +++ b/drivers/ata/pata_ixp4xx_cf.c > > > @@ -189,6 +189,10 @@ static __devinit int ixp4xx_pata_probe(struct platform_device *pdev) > > > data->cs0 = devm_ioremap(&pdev->dev, cs0->start, 0x1000); > > > data->cs1 = devm_ioremap(&pdev->dev, cs1->start, 0x1000); > > > > > > + if (!data->cs0 || !data->cs1) { > > > + return -ENOMEM; > > > + } > > > + > > > > You aren't following the Kernel CodingStyle there. > > > > See Documentation/CodingStyle: > > > > "Do not unnecessarily use braces where a single statement will do." > > > > + if (!data->cs0 || !data->cs1) > > + return -ENOMEM; > > This and nice printk message absence. :) Huh? What do you mean? Thanks, Brandon