From: Al Viro <viro@ftp.linux.org.uk>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Renumber AUDIT_TTY_[GS]ET
Date: Thu, 23 Aug 2007 20:31:21 +0100 [thread overview]
Message-ID: <20070823193121.GM21089@ftp.linux.org.uk> (raw)
In-Reply-To: <20070823073241.2c470cb5@laptopd505.fenrus.org>
On Thu, Aug 23, 2007 at 07:32:41AM -0700, Arjan van de Ven wrote:
> On Thu, 23 Aug 2007 10:19:53 +0100
> Al Viro <viro@ftp.linux.org.uk> wrote:
>
> > From: Miloslav Trmac <mitr@redhat.com>
> >
> > Renumber AUDIT_TTY_[GS]ET to avoid a conflict with netlink message
> > types already used in the wild.
>
> which are these? Were they in mainline or -mm before?
>
> also, if this is so sensitive, at least add something that says to never ever use 1014/1015...
AUDIT_TTY_*ET went into mainline directly and I'd missed the conflict with
the numbers already in use by audit-subtree patches. I *had* noticed when
pushing audit-subtree to -mm, swore at myself and renumbered those. Alas,
there's userland to deal with.
* auditctl has subtree support merged
* auditctl still doesn't have tty... support merged
* it's built with numbers matching the original patchset (1014/1015)
and binaries are released
* audit-subtree patchset is in RH beta kernel, also released
Vote of auditctl maintainer had been "renumber tty_...* until it's too late,
since that's the one userland doesn't support yet". The author of tty patches
agrees (see above) and I also think that this is the best way out of that mess.
Again, it's largely my fault - I'd missed the conflict in the first place and
hadn't reacted immediately.
prev parent reply other threads:[~2007-08-23 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-23 9:19 [PATCH] Renumber AUDIT_TTY_[GS]ET Al Viro
2007-08-23 14:32 ` Arjan van de Ven
2007-08-23 19:31 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070823193121.GM21089@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox