From: Jeff Dike <jdike@addtoit.com>
To: Blaisorblade <blaisorblade@yahoo.it>
Cc: user-mode-linux-devel@lists.sourceforge.net,
Satyam Sharma <satyam@infradead.org>,
Jeff Dike <jdike@addtoit.com>, Andrew Morton <akpm@osdl.org>,
Joe Perches <joe@perches.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [uml-devel] [PATCH 6/6] UML - Fix hostfs style
Date: Fri, 24 Aug 2007 11:21:27 -0400 [thread overview]
Message-ID: <20070824152127.GA7190@c2.user-mode-linux.org> (raw)
In-Reply-To: <200708231655.00034.blaisorblade@yahoo.it>
On Thu, Aug 23, 2007 at 04:54:59PM +0200, Blaisorblade wrote:
> > actually. Personally I'd prefer:
> >
> > else
> > type = OS_TYPE_DIR;
>
> I strongly agree with this style; beyond style itself, one strong reason is
> that joining statements hinder singlestepping through function code (it's
> easy to run gdb on UML, and anyway kgdb exists).
How does that help? gdb should stop as easily on a "else foo;" line as on
else
foo;
right?
Jeff
--
Work email - jdike at linux dot intel dot com
next prev parent reply other threads:[~2007-08-24 15:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-17 19:43 [PATCH 6/6] UML - Fix hostfs style Jeff Dike
2007-08-18 14:19 ` Satyam Sharma
2007-08-23 14:54 ` [uml-devel] " Blaisorblade
2007-08-24 15:21 ` Jeff Dike [this message]
2007-08-24 16:10 ` Blaisorblade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070824152127.GA7190@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@osdl.org \
--cc=blaisorblade@yahoo.it \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=satyam@infradead.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox