From: Paolo Ornati <ornati@fastwebnet.it>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "Bob Picco" <bob.picco@hp.com>,
"john stultz" <johnstul@us.ibm.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: "double" hpet clocksource && hard freeze [bisected]
Date: Fri, 24 Aug 2007 18:13:26 +0200 [thread overview]
Message-ID: <20070824181326.57ee5a2c@localhost> (raw)
In-Reply-To: <617E1C2C70743745A92448908E030B2A023EB8C4@scsmsx411.amr.corp.intel.com>
On Fri, 24 Aug 2007 09:04:22 -0700
"Luck, Tony" <tony.luck@intel.com> wrote:
> It is good to avoid registering two clocksources with the same name, but
> the fix might be a bit more fragile than the eariler one that temporarily
> marked the drivers/char/hpet.c one as CONFIG_IA64 only. Given that the
> hang went away when you applied the earlier patch, I conclude that the
> drivers/char/hpet.c code is the one that got selected when you had two
> "hpet" entries ... and that there is something wrong with that code that
> doesn't work right on x86_64. The fix to prevent registering a duplicate
> name is presumably working for you simply because arch/x86_64/kernel/hpet.c
> happens to get there first with its "hpet", so the drivers/char/hpet.c one
> is dropped. If something changed that reversed the order of these registrations,
> then you'd get the "hpet" clocksource that results in a hang.
100% agree
--
Paolo Ornati
Linux 2.6.23-rc3-g1a8f4610-dirty on x86_64
next prev parent reply other threads:[~2007-08-24 16:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-23 20:21 "double" hpet clocksource && hard freeze [bisected] Paolo Ornati
2007-08-23 20:22 ` Paolo Ornati
2007-08-23 20:41 ` Luck, Tony
2007-08-23 21:05 ` john stultz
2007-08-23 21:38 ` Bob Picco
2007-08-24 7:03 ` Paolo Ornati
2007-08-23 21:41 ` john stultz
2007-08-24 7:01 ` Paolo Ornati
2007-08-24 12:46 ` Bob Picco
2007-08-24 13:27 ` Paolo Ornati
2007-08-24 16:04 ` Luck, Tony
2007-08-24 16:13 ` Paolo Ornati [this message]
2007-08-24 18:17 ` john stultz
2007-08-27 20:34 ` Luiz Fernando N. Capitulino
2007-08-27 21:39 ` john stultz
2007-08-28 6:07 ` Paolo Ornati
2007-08-24 9:03 ` Paolo Ornati
2007-08-24 18:43 ` john stultz
-- strict thread matches above, loose matches on Subject: below --
2007-08-28 8:27 Clemens Ladisch
2007-08-28 20:21 ` Paolo Ornati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070824181326.57ee5a2c@localhost \
--to=ornati@fastwebnet.it \
--cc=bob.picco@hp.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox