Re: [Linux-fbdev-devel] [PATCH] uvesafb: select connector in Kconfig

Michal Januszewski
2007-08-26T09:44:22Z

On Sat, Aug 25, 2007 at 08:23:41AM -0700, Randy Dunlap wrote:

> There are 2 problems with this.
>
> a. CONNECTOR depends on NET, but select won't enable NET, so if
> NET is not enabled otherwise, CONNECTOR still won't build.
> This is a longstanding select/kconfig issue.
>
> b. CONNECTOR depends on NET, so if select did follow the depends
> chain and enable NET, it would be enabling the networking subsystem,
> which is something that should not be done quietly.
>
> select should only be used for enabling small library-like code
> (if even then). Avoid it whenever possible.

OK, thanks for pointing this out. Let's keep the original dependency
on CONNECTOR then.

Best regards,
Michal