public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Matthias Hensler <matthias@wspse.de>
Cc: Christian Hesse <mail@earthworm.de>,
	suspend2-devel@lists.tuxonice.net,
	Suspend2-users@lists.suspend2.net, linux-kernel@vger.kernel.org,
	suspend2-devel <suspend2-devel@lists.suspend2.net>,
	David Rodriguez <livuxman@gmail.com>
Subject: Re: [Suspend2-devel] Problem with CFS V20 and Suspend2/tuxonice
Date: Sat, 25 Aug 2007 21:02:23 +0200	[thread overview]
Message-ID: <20070825190223.GC15888@elte.hu> (raw)
In-Reply-To: <20070825184917.GA7945@kobayashi-maru.wspse.de>


* Matthias Hensler <matthias@wspse.de> wrote:

> > Same problem here: Core Duo, Kernel 2.6.22.5, Suspend 2.2.10, CFS 
> > v20.2.
> 
> Me too for 2.6.22.5, TuxOnIce 2.2.10 and Centrino based notebook.

possible bugfix below.

	Ingo

Index: linux-cfs-2.6.22.5.q/kernel/sched.c
===================================================================
--- linux-cfs-2.6.22.5.q.orig/kernel/sched.c
+++ linux-cfs-2.6.22.5.q/kernel/sched.c
@@ -5043,6 +5043,8 @@ static int migration_thread(void *data)
 		struct migration_req *req;
 		struct list_head *head;
 
+		try_to_freeze();
+
 		spin_lock_irq(&rq->lock);
 
 		if (cpu_is_offline(cpu)) {
@@ -5399,6 +5401,7 @@ migration_call(struct notifier_block *nf
 		p = kthread_create(migration_thread, hcpu, "migration/%d", cpu);
 		if (IS_ERR(p))
 			return NOTIFY_BAD;
+		p->flags |= PF_NOFREEZE;
 		kthread_bind(p, cpu);
 		/* Must be high prio: stop_machine expects to yield to it. */
 		rq = task_rq_lock(p, &flags);


  reply	other threads:[~2007-08-25 19:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1946b54f0708250423k75d5797fuc5b032be7e143f26@mail.gmail.com>
2007-08-25 11:29 ` Problem with CFS V20 and Suspend2/tuxonice David Rodriguez
2007-08-25 12:54   ` Fabio Comolli
2007-08-25 16:52     ` [Suspend2-devel] " Christian Hesse
2007-08-25 18:49       ` Matthias Hensler
2007-08-25 19:02         ` Ingo Molnar [this message]
2007-08-27 11:41           ` Pavel Machek
2007-08-27 12:11             ` Ingo Molnar
2007-08-27 12:25             ` Rafael J. Wysocki
2007-08-25 19:02       ` Ingo Molnar
2007-08-25 20:14         ` Christian Hesse
2007-08-25 19:01   ` Ingo Molnar
2007-08-25 19:49     ` Rafael J. Wysocki
2007-08-25 20:15     ` David Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070825190223.GC15888@elte.hu \
    --to=mingo@elte.hu \
    --cc=Suspend2-users@lists.suspend2.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=livuxman@gmail.com \
    --cc=mail@earthworm.de \
    --cc=matthias@wspse.de \
    --cc=suspend2-devel@lists.suspend2.net \
    --cc=suspend2-devel@lists.tuxonice.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox