[2.6 patch] i386: unexport machine_id

[2.6 patch] i386: unexport machine_id

[Adrian Bunk]

This patch removes the unused EXPORT_SYMBOL(machine_id).

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

This patch has been sent on:
- 14 Aug 2007

--- a/arch/i386/kernel/setup.c
+++ b/arch/i386/kernel/setup.c
@@ -86,9 +86,6 @@ unsigned long mmu_cr4_features;
 
 /* for MCA, but anyone else can use it if they want */
 unsigned int machine_id;
-#ifdef CONFIG_MCA
-EXPORT_SYMBOL(machine_id);
-#endif
 unsigned int machine_submodel_id;
 unsigned int BIOS_revision;
 unsigned int mca_pentium_flag;

Re: [2.6 patch] i386: unexport machine_id

[Andrew Morton]

On Mon, 27 Aug 2007 23:28:08 +0200 Adrian Bunk <bunk@kernel.org> wrote:

> This patch removes the unused EXPORT_SYMBOL(machine_id).
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> ---
> 
> This patch has been sent on:
> - 14 Aug 2007
> 
> --- a/arch/i386/kernel/setup.c
> +++ b/arch/i386/kernel/setup.c
> @@ -86,9 +86,6 @@ unsigned long mmu_cr4_features;
>  
>  /* for MCA, but anyone else can use it if they want */
>  unsigned int machine_id;
> -#ifdef CONFIG_MCA
> -EXPORT_SYMBOL(machine_id);
> -#endif
>  unsigned int machine_submodel_id;
>  unsigned int BIOS_revision;
>  unsigned int mca_pentium_flag;

You know my position on removal of exports with no warning.

If the relevant maintainer chooses to apply the patch then ho hum I have
other things to think about.  Your best shot at getting this sort of thing
merged would be to cc the appropriate maintainer.

Or, better, use __deprecated_for_modules.  That's what it was added for.

Re: [2.6 patch] i386: unexport machine_id

[Arjan van de Ven]

On Tue, 28 Aug 2007 01:07:41 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> You know my position on removal of exports with no warning.

I know it (and don't quite agree but ok)
> 
> If the relevant maintainer chooses to apply the patch then ho hum I
> have other things to think about.  Your best shot at getting this
> sort of thing merged would be to cc the appropriate maintainer.
> 
> Or, better, use __deprecated_for_modules.  That's what it was added
> for. -

and/or use EXPORT_UNUSED_SYMBOL so that people at least have the option
to not suffer the overhead *now*.

[2.6 patch] i386: unexport machine_id

[Adrian Bunk]

This patch removes the unused EXPORT_SYMBOL(machine_id).

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
--- a/arch/i386/kernel/setup.c
+++ b/arch/i386/kernel/setup.c
@@ -86,9 +86,6 @@ unsigned long mmu_cr4_features;
 
 /* for MCA, but anyone else can use it if they want */
 unsigned int machine_id;
-#ifdef CONFIG_MCA
-EXPORT_SYMBOL(machine_id);
-#endif
 unsigned int machine_submodel_id;
 unsigned int BIOS_revision;
 unsigned int mca_pentium_flag;