From: "J. Bruce Fields" <bfields@fieldses.org>
To: "Dr. David Alan Gilbert" <linux@treblig.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
neilb@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add source address to sunrpc svc errors
Date: Mon, 27 Aug 2007 17:43:33 -0400 [thread overview]
Message-ID: <20070827214333.GM3118@fieldses.org> (raw)
In-Reply-To: <20070825150927.GA29335@gallifrey>
On Sat, Aug 25, 2007 at 04:09:27PM +0100, Dr. David Alan Gilbert wrote:
> This patch adds the address of the client that caused an
> error in sunrpc/svc.c so that you get errors that look like:
>
> svc: 192.168.66.28, port=709: unknown version (3 for prog 100003, nfsd)
>
> I've seen machines which get bunches of unknown version or similar
> errors from time to time, and while the recent patch to add
> the service helps to find which service has the wrong version it doesn't
> help find the potentially bad client.
Looks like a reasonable idea to me, thanks! Any objection to just
calling it "svc_printk" instead of "svc_printkerr"?
I also wonder whether these shouldn't all be dprintk's instead of
printk's. One misbehaving client could create a lot of noise in the
logs.
--b.
next prev parent reply other threads:[~2007-08-27 21:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-25 1:26 [PATCH] Add source address to sunrpc svc errors Dr. David Alan Gilbert
2007-08-25 1:56 ` Randy Dunlap
2007-08-25 15:09 ` Dr. David Alan Gilbert
2007-08-27 21:43 ` J. Bruce Fields [this message]
2007-08-28 18:03 ` Dr. David Alan Gilbert
2007-08-28 18:56 ` J. Bruce Fields
2007-09-01 19:27 ` Dr. David Alan Gilbert
2007-08-28 19:12 ` Valdis.Kletnieks
2007-08-28 19:19 ` J. Bruce Fields
2007-08-29 18:26 ` Valdis.Kletnieks
2007-08-29 13:37 ` Peter Staubach
2007-08-29 13:50 ` J. Bruce Fields
2007-08-29 19:41 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070827214333.GM3118@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=neilb@suse.de \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox