public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] scripts/ver_linux : correct printing of binutils version
@ 2007-08-01 23:21 Jesper Juhl
  2007-08-28 19:25 ` Sam Ravnborg
  0 siblings, 1 reply; 2+ messages in thread
From: Jesper Juhl @ 2007-08-01 23:21 UTC (permalink / raw)
  To: Sam Ravnborg; +Cc: lkml, Linux Kernel Mailing List, Andrew Morton, Jesper Juhl

Hi,

Currently scripts/ver_linux prints "Binutils" or other random 
information for the version number in the "binutils" output line 
on some distributions. This patch corrects that.

When I initially submitted a patch to correct that, I was not aware 
that the output from "ld -v" could differ as much as it turned out 
it can, so my original fix turned out to not cover all bases.
This patch works correctly with all the different "ld -v" output 
that people posted in replys to my first patch, so it should be a 
clear win over what we have currently.

Please apply.


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

 scripts/ver_linux |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/scripts/ver_linux b/scripts/ver_linux
index 8f8df93..27a5a21 100755
--- a/scripts/ver_linux
+++ b/scripts/ver_linux
@@ -21,9 +21,7 @@ gcc --version 2>&1| grep gcc | awk \
 make --version 2>&1 | awk -F, '{print $1}' | awk \
       '/GNU Make/{print "Gnu make              ",$NF}'
 
-ld -v | awk -F\) '{print $1}' | awk \
-'/BFD/{print "binutils              ",$NF} \
-/^GNU/{print "binutils              ",$4}'
+echo "binutils               $(ld -v | egrep -o '[0-9]+\.[0-9\.]+')"
 
 echo -n "util-linux             "
 fdformat --version | awk '{print $NF}' | sed -e s/^util-linux-// -e s/\)$//





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] scripts/ver_linux : correct printing of binutils version
  2007-08-01 23:21 [PATCH] scripts/ver_linux : correct printing of binutils version Jesper Juhl
@ 2007-08-28 19:25 ` Sam Ravnborg
  0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2007-08-28 19:25 UTC (permalink / raw)
  To: Jesper Juhl; +Cc: lkml, Linux Kernel Mailing List, Andrew Morton

On Thu, Aug 02, 2007 at 01:21:15AM +0200, Jesper Juhl wrote:
> Hi,
> 
> Currently scripts/ver_linux prints "Binutils" or other random 
> information for the version number in the "binutils" output line 
> on some distributions. This patch corrects that.
> 
> When I initially submitted a patch to correct that, I was not aware 
> that the output from "ld -v" could differ as much as it turned out 
> it can, so my original fix turned out to not cover all bases.
> This patch works correctly with all the different "ld -v" output 
> that people posted in replys to my first patch, so it should be a 
> clear win over what we have currently.
> 
> Please apply.

Done,

	Sam

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-08-28 19:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-01 23:21 [PATCH] scripts/ver_linux : correct printing of binutils version Jesper Juhl
2007-08-28 19:25 ` Sam Ravnborg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox