Re: [patch v2 1/1] md: Software Raid autodetect dev list not array

Michael Evans
2007-08-26T19:19:15Z

On 8/26/07, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> On Sun, 26 Aug 2007 04:51:24 -0700 Michael J. Evans wrote:
>
> > From: Michael J. Evans <mjevans1983@gmail.com>
> >

>
> Is there any way to tell the user what device (or partition?) is
> bein skipped? This printk should just print (confirm) that
> node_detected_dev is NULL. Shouldn't it just print <dev> in
> major:minor format?
>

It would be possible with the MAJOR() and MINOR() macros to do this...
however it doesn't really help out much during troubleshooting. I
tried using the bdevname function like the function that calls this
one uses, however, it wants a struct device_block... which I tried
getting with:

container_of(dev, struct block_device, bd_dev)

Of course this didn't quite work out, I got kernel panics on my two
trial attempts.

Here's a skip from a dmesg where I added a printk right under the line
in question.

[ 63.033532] sd 11:0:0:0: [sdk] 976773168 512-byte hardware sectors
(500108 MB)
[ 63.039842] sd 11:0:0:0: [sdk] Write Protect is off
[ 63.046012] sd 11:0:0:0: [sdk] Mode Sense: 00 3a 00 00
[ 63.046025] sd 11:0:0:0: [sdk] Write cache: enabled, read cache:
enabled, doesn't support DPO or FUA
[ 63.052309] sdk: sdk1 sdk2 sdk3 sdk4 sdk5 sdk6 sdk7 sdk8 sdk9
sdk10 sdk11 sdk12 sdk13 sdk14 sdk15
[ 63.082546] md: Autodetect-buffering the above device.
[ 63.088893] md: Autodetect-buffering the above device.
[ 63.095053] md: Autodetect-buffering the above device.
[ 63.101082] md: Autodetect-buffering the above device.
[ 63.106956] md: Autodetect-buffering the above device.
[ 63.112596] md: Autodetect-buffering the above device.
[ 63.117998] md: Autodetect-buffering the above device.
[ 63.123396] md: Autodetect-buffering the above device.
[ 63.128789] md: Autodetect-buffering the above device.
[ 63.134182] md: Autodetect-buffering the above device.
[ 63.139576] md: Autodetect-buffering the above device.
[ 63.144970] md: Autodetect-buffering the above device.
[ 63.150360] md: Autodetect-buffering the above device.
[ 63.155749] md: Autodetect-buffering the above device.
[ 63.161498] sd 11:0:0:0: [sdk] Attached SCSI disk

> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>