From: Ingo Molnar <mingo@elte.hu>
To: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
Cc: nickpiggin@yahoo.com.au, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [patch] sched: fix broken smt/mc optimizations with CFS
Date: Wed, 29 Aug 2007 05:42:14 +0200 [thread overview]
Message-ID: <20070829034214.GA30551@elte.hu> (raw)
In-Reply-To: <20070828222718.GI1894@linux-os.sc.intel.com>
* Siddha, Suresh B <suresh.b.siddha@intel.com> wrote:
> On Mon, Aug 27, 2007 at 12:31:03PM -0700, Siddha, Suresh B wrote:
> > Essentially I observed that nice 0 tasks still endup on two cores of same
> > package, with out getting spread out to two different packages. This behavior
> > is same with out this fix and this fix doesn't help in any way.
>
> Ingo, Appended patch seems to fix the issue and as far as I can test,
> seems ok to me.
thanks! I've queued your fix up for .23 merge. I've done a quick test
and it indeed seems to work well.
> This is a quick fix for .23. Peter Williams and myself plan to look at
> code cleanups in this area (HT/MC optimizations) post .23
>
> BTW, with this fix, do you want to retain the current FUZZ value?
what value would you suggest? I was thinking about using
busiest_rq->curr->load.weight instead, to always keep rotating tasks.
Ingo
next prev parent reply other threads:[~2007-08-29 3:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 1:01 [patch] sched: fix broken smt/mc optimizations with CFS Siddha, Suresh B
2007-08-23 10:38 ` Ingo Molnar
2007-08-23 11:54 ` Ingo Molnar
2007-08-23 12:13 ` Ingo Molnar
2007-08-23 17:42 ` Daniel Walker
2007-08-27 19:19 ` Siddha, Suresh B
2007-08-27 19:23 ` Ingo Molnar
2007-08-27 19:31 ` Siddha, Suresh B
2007-08-28 22:27 ` Siddha, Suresh B
2007-08-29 3:42 ` Ingo Molnar [this message]
2007-09-04 23:35 ` Chuck Ebbert
2007-09-04 23:46 ` Siddha, Suresh B
2007-09-05 10:51 ` Ingo Molnar
2007-08-27 16:32 ` Torsten Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070829034214.GA30551@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox