From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Andre Haupt <andre@finow14.de>
Cc: Matthew Wilcox <matthew@wil.cx>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [KJ][patch 3/3] VIDC20: use abs() from kernel.h instead of own definition
Date: Thu, 30 Aug 2007 13:22:37 +0100 [thread overview]
Message-ID: <20070830122237.GE10088@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20070830115059.GA17168@ahaupt-debian-vm.localdomain>
On Thu, Aug 30, 2007 at 01:50:59PM +0200, Andre Haupt wrote:
> On Thu, Aug 30, 2007 at 05:17:47AM -0600, Matthew Wilcox wrote:
> > On Thu, Aug 30, 2007 at 12:40:38PM +0200, andre@finow14.de wrote:
> > > - diff_int = my_abs(rate_ext-rate);
> > > - diff_ext = my_abs(rate_int-rate);
> > > + diff_int = abs(rate_ext-rate);
> > > + diff_ext = abs(rate_int-rate);
> >
> > Nothing to do with the patch, but is this really correct? Surely it
> > should be diff_ext = abs(rate_ext-rate) ?
>
> hmmh, not sure about this ...
No idea. The support for external clocking came from someone else
(I was never able to work it out myself).
I can only assume that the code as it stands does work. So let's
remain bug-compatible until there's a proven problem.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
prev parent reply other threads:[~2007-08-30 12:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070830102551.131398783@finow14.de>
2007-08-30 10:36 ` [KJ][patch 1/3] IDT77252: use abs() from kernel.h where appropriate andre
2007-08-30 10:37 ` [KJ][patch 2/3] CIFS SMB: " andre
2007-08-30 10:40 ` [KJ][patch 3/3] VIDC20: use abs() from kernel.h instead of own definition andre
2007-08-30 11:17 ` Matthew Wilcox
2007-08-30 11:50 ` Andre Haupt
2007-08-30 12:22 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070830122237.GE10088@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=andre@finow14.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox