From: Alexey Dobriyan <adobriyan@sw.ru>
To: Hugh Dickins <hugh@veritas.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Len Brown <lenb@kernel.org>,
Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@suse.de>, Jan Beulich <jbeulich@novell.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix maxcpus=1 oops in show_stat()
Date: Fri, 31 Aug 2007 11:37:46 +0400 [thread overview]
Message-ID: <20070831073746.GA15151@localhost.sw.ru> (raw)
In-Reply-To: <Pine.LNX.4.64.0708310404210.4873@blonde.wat.veritas.com>
On Fri, Aug 31, 2007 at 04:26:50AM +0100, Hugh Dickins wrote:
> --- 2.6.23-rc4/init/main.c
> +++ linux/init/main.c
> @@ -397,10 +397,6 @@ static void __init smp_init(void)
> {
> unsigned int cpu;
>
> -#ifndef CONFIG_HOTPLUG_CPU
> - cpu_possible_map = cpu_present_map;
> -#endif
> -
> /* FIXME: This should be done in userspace --RR */
> for_each_present_cpu(cpu) {
> if (num_online_cpus() >= max_cpus)
> @@ -545,10 +541,6 @@ asmlinkage void __init start_kernel(void
> setup_arch(&command_line);
> setup_command_line(command_line);
> unwind_setup();
> -#ifndef CONFIG_HOTPLUG_CPU
> - if (max_cpus < 2)
> - cpu_possible_map = cpu_online_map;
> -#endif
> setup_per_cpu_areas();
> smp_prepare_boot_cpu(); /* arch-specific boot-cpu hooks */
>
Works here, I'll try on another box soon.
next prev parent reply other threads:[~2007-08-31 7:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-28 11:14 2.6.23-rc4: maxcpus still broken Alexey Dobriyan
2007-08-28 23:35 ` Michal Piotrowski
2007-08-29 4:39 ` Alexey Dobriyan
2007-08-29 5:03 ` Hugh Dickins
2007-08-29 5:23 ` Alexey Dobriyan
2007-08-29 6:41 ` Len Brown
2007-08-29 7:25 ` Alexey Dobriyan
2007-08-31 3:26 ` [PATCH] fix maxcpus=1 oops in show_stat() Hugh Dickins
2007-08-31 4:33 ` Linus Torvalds
2007-08-31 7:37 ` Alexey Dobriyan [this message]
2007-08-29 20:20 ` 2.6.23-rc4: maxcpus still broken Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070831073746.GA15151@localhost.sw.ru \
--to=adobriyan@sw.ru \
--cc=adobriyan@gmail.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=jbeulich@novell.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox