From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753810AbcIONPe (ORCPT <rfc822;w@1wt.eu>);
        Thu, 15 Sep 2016 09:15:34 -0400
Received: from galahad.ideasonboard.com ([185.26.127.97]:51319 "EHLO
        galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751020AbcIONP1 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 15 Sep 2016 09:15:27 -0400
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org,
        Johan Hovold <johan@hovoldconsulting.com>,
        Rui Miguel Silva <rmfrfs@gmail.com>,
        Sandeep Patil <sspatil@google.com>,
        Matt Porter <mporter@kernel.crashing.org>,
        John Stultz <john.stultz@linaro.org>, Rob Herring <robh@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>, Alex Elder <elder@linaro.org>,
        David Lin <dtwlin@google.com>,
        "Bryan O'Donoghue" <pure.logic@nexus-software.ie>,
        Vaibhav Agarwal <vaibhav.agarwal@linaro.org>,
        Mark Greer <mgreer@animalcreek.com>
Subject: Re: [patch 11/32] greybus: camera driver
Date: Thu, 15 Sep 2016 16:16:09 +0300
Message-ID: <2007086.FBCYJrjji1@avalon>
User-Agent: KMail/4.14.10 (Linux/4.4.6-gentoo; KDE/4.14.20; x86_64; ; )
In-Reply-To: <20160915122234.640367870@bubbles.kroah.org>
References: <20160914100949.GA6179@kroah.com> <20160915122141.650632149@bubbles.kroah.org> <20160915122234.640367870@bubbles.kroah.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Greg,

Thank you for the patch.

On Thursday 15 Sep 2016 14:23:51 Greg Kroah-Hartman wrote:
> This driver implements the Greybus camera protocol.
> 
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/greybus/camera.c    | 1400 ++++++++++++++++++++++++++++++++++++++++
>  drivers/greybus/gb-camera.h |  127 +++
>  2 files changed, 1527 insertions(+)
> 
> --- /dev/null
> +++ b/drivers/greybus/camera.c
> @@ -0,0 +1,1400 @@

[snip]

> +/* GB format to media code map */
> +static const struct gb_camera_fmt_info gb_fmt_info[] = {
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_UYVY8_1X16,
> +		.gb_format = 0x01,
> +		.bpp	   = 16,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_NV12_1x8,
> +		.gb_format = 0x12,
> +		.bpp	   = 12,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_NV21_1x8,
> +		.gb_format = 0x13,
> +		.bpp	   = 12,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_YU12_1x8,
> +		.gb_format = 0x16,
> +		.bpp	   = 12,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_YV12_1x8,
> +		.gb_format = 0x17,
> +		.bpp	   = 12,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_JPEG_1X8,
> +		.gb_format = 0x40,
> +		.bpp	   = 0,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_GB_CAM_METADATA_1X8,
> +		.gb_format = 0x41,
> +		.bpp	   = 0,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_GB_CAM_DEBUG_DATA_1X8,
> +		.gb_format = 0x42,
> +		.bpp	   = 0,
> +	},

These two formats will likely not be accepted in their current state in the 
media subsystem, I would propose just dropping them.

> +	{
> +		.mbus_code = V4L2_MBUS_FMT_SBGGR10_1X10,
> +		.gb_format = 0x80,
> +		.bpp	   = 10,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_SGBRG10_1X10,
> +		.gb_format = 0x81,
> +		.bpp	   = 10,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_SGRBG10_1X10,
> +		.gb_format = 0x82,
> +		.bpp	   = 10,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_SRGGB10_1X10,
> +		.gb_format = 0x83,
> +		.bpp	   = 10,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_SBGGR12_1X12,
> +		.gb_format = 0x84,
> +		.bpp	   = 12,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_SGBRG12_1X12,
> +		.gb_format = 0x85,
> +		.bpp	   = 12,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_SGRBG12_1X12,
> +		.gb_format = 0x86,
> +		.bpp	   = 12,
> +	},
> +	{
> +		.mbus_code = V4L2_MBUS_FMT_SRGGB12_1X12,
> +		.gb_format = 0x87,
> +		.bpp	   = 12,
> +	},
> +};

[snip]

-- 
Regards,

Laurent Pinchart