Re: [PATCH] skge: unbalanced parenthesis fix

Stephen Hemminger
2007-09-01T12:55:29Z

On Sat, 1 Sep 2007 08:10:12 +0200
Mariusz Kozlowski <m.kozlowski@tuxland.pl> wrote:

> Hello,
>
> This patch fixes unbalanced parenthesis.
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> drivers/net/skge.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.23-rc4-mm1-a/drivers/net/skge.h 2007-09-01 07:23:52.000000000 +0200
> +++ linux-2.6.23-rc4-mm1-b/drivers/net/skge.h 2007-09-01 07:37:55.000000000 +0200
> @@ -1351,7 +1351,7 @@ enum {
> PHY_M_PC_EN_DET_PLUS = 3<<8, /* Energy Detect Plus (Mode 2) */
> };
>
> -#define PHY_M_PC_MDI_XMODE(x) ((((u16)(x)<<5) & PHY_M_PC_MDIX_MSK)
> +#define PHY_M_PC_MDI_XMODE(x) (((u16)(x)<<5) & PHY_M_PC_MDIX_MSK)
>
> enum {
> PHY_M_PC_MAN_MDI = 0, /* 00 = Manual MDI configuration */

Since the macro is unused, I would rather just drop it.