Re: [PATCH] sched: Use show_regs() to improve __schedule_bug() output

Ingo Molnar
2007-10-22T12:35:31Z

* Satyam Sharma <satyam@infradead.org> wrote:

> BTW would something similar would be useful in __schedule_bug() too? I
> sure think so -- I'm not sure if EIP holds anything useful there, but
> CPU#, EFLAGS and the init_utsname() stuff would be definitely helpful
> ...
>
> [PATCH] sched: Use show_regs() to improve __schedule_bug() output
>
> A full register dump along with stack backtrace would make the
> "scheduling while atomic" message more helpful. Use show_regs()
> instead of dump_stack() for this. We already know we're atomic in here
> (that is why this function was called) so show_regs()'s atomicity
> expectations are guaranteed.
>
> Also, modify the output of the "BUG: scheduling while atomic:" header
> a bit to keep task->comm and task->pid together and preempt_count()
> after them.

thanks, applied.

Ingo