From: Daniel Walker <dwalker@mvista.com>
To: akpm@linux-foundation.org
Cc: Andi Kleen <ak@suse.de>
Cc: eranian@hpl.hp.com
Cc: B.Steinbrink@gmx.de
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] i386: fix a hang on stuck nmi watchdog
Date: Sat, 01 Sep 2007 13:54:17 -0700 [thread overview]
Message-ID: <20070901205417.305538884@mvista.com> (raw)
In the case when an nmi gets stucks the endflag stays equal to zero. This
causes the busy looping on other cpus to continue, even tho the nmi test
is done.
On my machine with out the change below the system would hang right after
check_nmi_watchdog(). The change below just sets endflag prior to checking
if the test was successful or not.
Signed-off-by: Daniel Walker <dwalker@mvista.com>
---
arch/i386/kernel/nmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.22/arch/i386/kernel/nmi.c
===================================================================
--- linux-2.6.22.orig/arch/i386/kernel/nmi.c
+++ linux-2.6.22/arch/i386/kernel/nmi.c
@@ -115,12 +115,12 @@ static int __init check_nmi_watchdog(voi
atomic_dec(&nmi_active);
}
}
+ endflag = 1;
if (!atomic_read(&nmi_active)) {
kfree(prev_nmi_count);
atomic_set(&nmi_active, -1);
return -1;
}
- endflag = 1;
printk("OK.\n");
/* now that we know it works we can reduce NMI frequency to
--
--
next reply other threads:[~2007-09-01 21:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-01 20:54 Daniel Walker [this message]
2007-09-01 21:33 ` [PATCH 1/1] i386: fix a hang on stuck nmi watchdog Stephane Eranian
2007-09-01 21:26 ` Daniel Walker
2007-09-01 21:45 ` Andi Kleen
2007-09-01 22:27 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070901205417.305538884@mvista.com \
--to=dwalker@mvista.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox