From: Jesper Juhl <jesper.juhl@gmail.com>
To: Satyam Sharma <satyam@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
James Bottomley <james.bottomley@steeleye.com>,
aacraid@adaptec.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_host()
Date: Sun, 2 Sep 2007 22:03:39 +0200 [thread overview]
Message-ID: <200709022203.39922.jesper.juhl@gmail.com> (raw)
In-Reply-To: <alpine.LFD.0.999.0709030142490.29617@enigma.security.iitk.ac.in>
On Sunday 02 September 2007 22:13:49 Satyam Sharma wrote:
>
> drivers/scsi/ips.c: In function ‘ips_register_scsi’:
> drivers/scsi/ips.c:6869:
> warning: ignoring return value of ‘scsi_add_host’, declared with attribute warn_unused_result
>
> scsi_add_host() is __must_check, so let's check it's return and cleanup
> appropriately on errors.
>
> Signed-off-by: Satyam Sharma <satyam@infradead.org>
>
[snip]
Something seems to be wrong either at your end or mine
> + IPS_PRINTK(KERN_WARNING, ha->pcidev, "Unable to add SCSI host¥n");
This should end with a newline "\n" but I'm seeing "¥n" ...
/Jesper
next prev parent reply other threads:[~2007-09-02 20:07 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.0.999.0709022344550.27844@enigma.security.iitk.ac.i n>
2007-09-02 20:02 ` [-mm patchset] War on warnings Satyam Sharma
2007-09-02 20:04 ` Jesper Juhl
2007-09-02 20:39 ` Satyam Sharma
2007-09-02 20:30 ` Jesper Juhl
2007-09-02 20:07 ` [PATCH -mm] sisusbvga: Fix bug and build warnings Satyam Sharma
2007-09-02 20:11 ` Jesper Juhl
2007-09-02 20:32 ` Satyam Sharma
2007-09-02 20:23 ` Jesper Juhl
2007-09-02 21:18 ` Alistair John Strachan
2007-09-02 21:38 ` Satyam Sharma
2007-09-02 22:27 ` Satyam Sharma
2007-09-09 21:32 ` patch usb-sisusbvga-fix-bug-and-build-warnings.patch added to gregkh-2.6 tree gregkh
2007-09-02 20:09 ` [PATCH -mm] sunrpc svc: Shut up bogus uninitialized variable warning Satyam Sharma
2007-09-02 20:11 ` [PATCH -mm] net/wireless/sysfs.c: Shut up build warning Satyam Sharma
2007-09-02 20:24 ` Johannes Berg
2007-09-02 20:12 ` [PATCH -mm] drivers/usb/serial/bus.c: Fix incompatible pointer type warning Satyam Sharma
2007-09-02 20:13 ` [PATCH -mm] IPS SCSI driver: Check return of scsi_add_host() Satyam Sharma
2007-09-02 20:03 ` Jesper Juhl [this message]
2007-09-02 20:32 ` Jeff Garzik
2007-09-02 22:39 ` Satyam Sharma
2007-09-02 20:15 ` [PATCH -mm] sb16: Shut up uninitialized var build warning Satyam Sharma
2007-09-02 22:06 ` Rene Herman
2007-09-02 22:34 ` Satyam Sharma
2007-09-20 17:52 ` Denys Vlasenko
2007-09-22 4:20 ` Rene Herman
2007-09-02 20:16 ` [PATCH -mm] drivers/mmc/core/bus.c: Fix unused var warning Satyam Sharma
2007-09-03 9:04 ` Pierre Ossman
2007-09-02 20:18 ` [PATCH -mm] I2O: Fix "defined but not used" build warnings Satyam Sharma
2007-09-02 20:20 ` [PATCH -mm] mpt fusion: Shut up uninitialized variable warnings Satyam Sharma
2007-09-02 20:21 ` [PATCH -mm] es18xx: Shut up uninitialized var build warning Satyam Sharma
2007-09-02 22:14 ` Rene Herman
2007-09-02 20:22 ` [PATCH -mm] drivers/md/: Shut up uninitialized variable warnings Satyam Sharma
2007-09-02 20:34 ` Jeff Garzik
2007-09-02 20:57 ` Satyam Sharma
2007-09-02 20:23 ` [PATCH -mm] DC395x SCSI driver: Shut up uninitialized variable build warning Satyam Sharma
2007-09-02 20:23 ` Jeff Garzik
2007-09-02 20:49 ` Satyam Sharma
2007-09-02 20:43 ` Jeff Garzik
2007-09-02 20:24 ` [PATCH -mm] i386 cpuid_count: Fix argument signedness warnings Satyam Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709022203.39922.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=aacraid@adaptec.com \
--cc=james.bottomley@steeleye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=satyam@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox