Re: [PATCH] fujtisu application panel driver

Jason Uhlenkott
2007-07-05T01:34:40Z

On Mon, Jul 02, 2007 at 11:17:24 -0700, Stephen Hemminger wrote:
> +static int __init apanel_init(void)
> +{
> + void __iomem *bios;
> + u8 devno;
> + int found = 0;
> +
> + if (!dmi_check_system(apanel_dmi_table)) {
> + printk(KERN_WARNING "apanel: DMI information does not match\n");
> + if (!force)
> + return -ENODEV;
> + }
> + BUG_ON(!keymap);

If force=1 and there's no DMI match, we're guaranteed to pop this BUG_ON.

> +
> + device_chip[devno] = (enum apanel_chip) chip;
> + ++found;
> + }
> + }
> + iounmap(bios);

This isn't the address we got from ioremap (although it happens to
work, since iounmap internally masks it against PAGE_MASK).