Re: [PATCH] fujtisu application panel driver

Stephen Hemminger
2007-09-03T08:58:42Z

On Mon, 2 Jul 2007 15:16:30 -0400
"Dmitry Torokhov" <dmitry.torokhov@gmail.com> wrote:

> Hi Stephen,
>
> On 7/2/07, Stephen Hemminger <shemminger@linux-foundation.org> wrote:
> > This driver supports the application buttons on some Fujitsu Lifebook laptops.
> > These buttons are read via the SMBus, for more details see:
> > http://apanel.sourceforge.net/tech.php
> > The buttons are handled as by the regular input system.
> > Two models are detected now, but other Fujitsu laptop's have
> > keys that may work similarly.
> >
> > It is based on the earlier apanel driver done by Jochen Eisenger, but
> > with many changes. The original driver used ioctl's and a separate
> > user space program; this version hooks into the input subsystem so
> > that the normal Gnome/KDE shortcuts work without any userspace
> > changes.
> >
>
> Thank you very much for updating the patch. I have a couple of requests though:
>
> 1. LEDs shoud use the generic led subsystem instead of input layer. I
> do not have plans of adding any more LED_XXX constants and I think
> that adding any LEDs not directly relating to keyboard state was a
> mistake.

No, way to much work for one stinking LED.
Also there is existing application support for legacy LED_MAIL through
input subsystem, and no application support for mail led through LED
subsystem.

> 2. It would be nice if driver supported changing its keymaps now that
> we allow overriding default getkeycode() and setkeycode().

No, this drivers mapping table is from bits to key codes, not scan codes to keycodes.
Each key is a bit in the scan code, so hitting A and B key generates
scancode of : 0xC = 0x4 | 0x8.
get/setkeycode is designed for keyboards where each key generates different
unique code.

> 3. Do not aaccess input_dev->private directly. input_set_drvdata() and
> input+_getdrvdata shoudl be used.

New version of driver has to use input_polled_dev->private directly.