Re: [patches] [patch 3/5] x86: Add PCI extended config space access for AMD Barcelona

H. Peter Anvin
2007-09-05T10:15:52Z

Robert Richter wrote:
> On 05.09.07 06:58:58, H. Peter Anvin wrote:
>
>>> But at the moment there is no need for further discussion on this subject
>>> because Andi refuses to add support for Barcelona CF8/CFC ECS access.
>>>
>> Well, they don't add any functionality, do they? As such, I would agree
>> with Andi -- we only need one method which can (correctly) access the
>> full configuration space, since it'll look the same on the bus anyway.
>
> PCI Devices will not be the same on the bus since PCI read/write
> functions will have different behavior. Without the patches you will
> get an error when accessing ECS with CF8. We need ECS access for
> patches that setups local interrupt vectors. This patches will be
> released soon.

You're missing the point. How will the PCI bus transactions be
different when using MMCONFIG versus your extended CF8 version?

> Btw, this patch fixes also config space access with proc/sys fs and
> lspci. I see this as an added functionality as well.

The latter implies the former. Again, how does this differ from MMCONFIG?

-hpa