Re: [-mm PATCH] Memory controller improve user interface (v3)

Balbir Singh
2007-09-03T19:51:16Z

Paul Menage wrote:
> On 9/2/07, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>> - s += sprintf(s, "%lu\n", *val);
>> + if (read_strategy)
>> + s += read_strategy(*val, s);
>> + else
>> + s += sprintf(s, "%lu\n", *val);
>
> This would be better as %llu
>

Hi, Paul,

This does not need fixing, since the other counters like failcnt are
still unsigned long

>> + tmp = simple_strtoul(buf, &end, 10);
>
> and this as simple_strtoull()
>

Will do, thanks!