From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755869AbXIEAHS (ORCPT ); Tue, 4 Sep 2007 20:07:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754729AbXIEAHG (ORCPT ); Tue, 4 Sep 2007 20:07:06 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:57102 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754316AbXIEAHF (ORCPT ); Tue, 4 Sep 2007 20:07:05 -0400 Date: Tue, 4 Sep 2007 17:00:58 -0700 From: Andrew Morton To: Mike Travis Cc: clameter@sgi.com, steiner@sgi.com, ak@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kamalesh@linux.vnet.ibm.com Subject: Re: [PATCH 3/6] x86: Convert cpu_sibling_map to be a per cpu variable (v2) (fwd) Message-Id: <20070904170058.a55b4284.akpm@linux-foundation.org> In-Reply-To: <46DDE623.1090402@sgi.com> References: <46DDC017.4040301@sgi.com> <20070904141055.e00a60d7.akpm@linux-foundation.org> <46DDE623.1090402@sgi.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.19; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > On Tue, 04 Sep 2007 16:11:31 -0700 Mike Travis wrote: > > > > It'd be better to convert the unconverted architectures? > > I can easily do the changes for ia64 and test them. I don't have the capability > of testing on the powerpc. > > And are you asking for just the changes to fix the build problem, or the whole > set of the changes that were made for x86_64 and i386 in regards to converting > NR_CPU arrays to per cpu data? Well... it'd be better to have all architectures doing the same thing. If that's impractical then we should at least implement suitable accessor functions into the arch so that core code doesn't need to handle some architectures one way and others the other way.