[PATCH] Override 80-wire cable detection for Toshiba S1800-814

[PATCH] Override 80-wire cable detection for Toshiba S1800-814

[Daniel Exner]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

Hi!

Please CC me, as I'm currently not subscribed to this list, thx.

Attached patch will add above mentioned Laptop Model to whitelist for both 
pata_ali and alim15x3, as it is correctly detected as 40-wire connected but 
this cable is short enough to still do transfers higher than UDMA33.
Don't know if this is also true for other S1800 Laptops cause I own only one.

I hope I did this correctly as this is my first Patch Mail to LKML :)
-- 
Greetings
Daniel Exner

[-- Attachment #2: patchAli_pata.patch --]
[-- Type: text/x-diff, Size: 840 bytes --]

--- linux-2.6.22.old/drivers/ata/pata_ali.c	2007-08-29 23:27:53.000000000 +0200
+++ linux-2.6.22/drivers/ata/pata_ali.c	2007-08-29 23:14:37.000000000 +0200
@@ -48,6 +48,13 @@
 			DMI_MATCH(DMI_BOARD_VERSION, "OmniBook N32N-736"),
 		},
 	},
+	{
+		.ident = "Toshiba Satelite S1800-814",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "S1800-814"),
+		},
+	}, 
 	{ }
 };
 
--- linux-2.6.22.old/drivers/ide/pci/alim15x3.c	2007-08-29 22:17:14.000000000 +0200
+++ linux-2.6.22/drivers/ide/pci/alim15x3.c	2007-08-29 22:56:27.000000000 +0200
@@ -596,6 +596,13 @@
 			DMI_MATCH(DMI_BOARD_VERSION, "OmniBook N32N-736"),
 		},
 	},
+	{
+		.ident = "Toshiba Satellite S1800-814",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "S1800-814"),
+		},
+	},
 	{ }
 };
 

Re: [PATCH] Override 80-wire cable detection for Toshiba S1800-814

[Alan Cox]

On Wed, 29 Aug 2007 23:41:13 +0200
Daniel Exner <dex@dragonslave.de> wrote:

> Hi!
> 
> Please CC me, as I'm currently not subscribed to this list, thx.
> 
> Attached patch will add above mentioned Laptop Model to whitelist for both 
> pata_ali and alim15x3, as it is correctly detected as 40-wire connected but 
> this cable is short enough to still do transfers higher than UDMA33.
> Don't know if this is also true for other S1800 Laptops cause I own only one.

Looks good to me - does need a Signed-off-by: line however

[PATCH] Override 80-wire cable detection for Toshiba S1800-814 (resend)

[Daniel Exner]

[-- Attachment #1: Type: text/plain, Size: 115 bytes --]

Hi!

Please CC me, as I'm currently not subscribed to this list, thx.

Another try :)


-- 
Greetings
Daniel Exner

[-- Attachment #2: patchAli_pata.patch --]
[-- Type: text/x-diff, Size: 1088 bytes --]

Add Toshiba S1800-814 to whitelist for both 
pata_ali and alim15x3, as it is correctly detected as 40-wire connected but 
this cable is short enough to still use transfer modes higher than UDMA33.

Signed-off-by: Daniel Exner <dex@dragonslave.de>

--- linux-2.6.22.old/drivers/ata/pata_ali.c	2007-08-29 23:27:53.000000000 +0200
+++ linux-2.6.22/drivers/ata/pata_ali.c	2007-08-29 23:14:37.000000000 +0200
@@ -48,6 +48,13 @@
 			DMI_MATCH(DMI_BOARD_VERSION, "OmniBook N32N-736"),
 		},
 	},
+	{
+		.ident = "Toshiba Satelite S1800-814",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "S1800-814"),
+		},
+	}, 
 	{ }
 };
 
--- linux-2.6.22.old/drivers/ide/pci/alim15x3.c	2007-08-29 22:17:14.000000000 +0200
+++ linux-2.6.22/drivers/ide/pci/alim15x3.c	2007-08-29 22:56:27.000000000 +0200
@@ -596,6 +596,13 @@
 			DMI_MATCH(DMI_BOARD_VERSION, "OmniBook N32N-736"),
 		},
 	},
+	{
+		.ident = "Toshiba Satellite S1800-814",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "S1800-814"),
+		},
+	},
 	{ }
 };
 

Re: [PATCH] Override 80-wire cable detection for Toshiba S1800-814 (resend)

[Bartlomiej Zolnierkiewicz]

On Friday 31 August 2007, Daniel Exner wrote:
> Hi!
> 
> Please CC me, as I'm currently not subscribed to this list, thx.

applied but please inline patches instead of attaching them next time
(makes it much easier to review/apply them)