* [PATCH] [input] USB touchscreen
@ 2007-09-06 21:29 Vladimir Shebordaev
2007-09-07 1:34 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: Vladimir Shebordaev @ 2007-09-06 21:29 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: dmitry.torokhov, linux-kernel, Vladimir Shebordaev
This patch fixes a nasty typo in usbtouchscreen driver.
The typo is inherited from the original mtouchusb. It
used to make the input subsytem to incorrectly
report the physical device ids to userspace that in turn
is much confusing for, e.g. XInput hotplug facilities in
setups with multiple identical touchscreens.
Signed-off-by: Vladimir Shebordaev <vshebordaev@mail.ru>
---
drivers/input/touchscreen/usbtouchscreen.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c
index e3f2285..c32f447 100644
--- a/drivers/input/touchscreen/usbtouchscreen.c
+++ b/drivers/input/touchscreen/usbtouchscreen.c
@@ -734,7 +734,7 @@ static int usbtouch_probe(struct usb_interface *intf,
le16_to_cpu(udev->descriptor.idProduct));
usb_make_path(udev, usbtouch->phys, sizeof(usbtouch->phys));
- strlcpy(usbtouch->phys, "/input0", sizeof(usbtouch->phys));
+ strlcat(usbtouch->phys, "/input0", sizeof(usbtouch->phys));
input_dev->name = usbtouch->name;
input_dev->phys = usbtouch->phys;
--
1.5.2.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] [input] USB touchscreen
2007-09-06 21:29 [PATCH] [input] USB touchscreen Vladimir Shebordaev
@ 2007-09-07 1:34 ` Dmitry Torokhov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2007-09-07 1:34 UTC (permalink / raw)
To: Vladimir Shebordaev; +Cc: linux-kernel, Vladimir Shebordaev
On Thursday 06 September 2007 17:29, Vladimir Shebordaev wrote:
> This patch fixes a nasty typo in usbtouchscreen driver.
>
> The typo is inherited from the original mtouchusb. It
> used to make the input subsytem to incorrectly
> report the physical device ids to userspace that in turn
> is much confusing for, e.g. XInput hotplug facilities in
> setups with multiple identical touchscreens.
>
> Signed-off-by: Vladimir Shebordaev <vshebordaev@mail.ru>
Applied, thank you Vladimir.
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] [input] USB touchscreen
@ 2007-09-06 22:01 Vladimir Shebordaev
0 siblings, 0 replies; 5+ messages in thread
From: Vladimir Shebordaev @ 2007-09-06 22:01 UTC (permalink / raw)
To: linux-kernel
This patch fixes a nasty typo in usbtouchscreen driver.
The typo is inherited from the original mtouchusb. It
used to make the input subsytem to incorrectly
report the physical device ids to userspace that in turn
is much confusing for, e.g. XInput hotplug facilities in
setups with multiple identical touchscreens.
Signed-off-by: Vladimir Shebordaev <vshebordaev@mail.ru>
---
drivers/input/touchscreen/usbtouchscreen.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c
index e3f2285..c32f447 100644
--- a/drivers/input/touchscreen/usbtouchscreen.c
+++ b/drivers/input/touchscreen/usbtouchscreen.c
@@ -734,7 +734,7 @@ static int usbtouch_probe(struct usb_interface *intf,
le16_to_cpu(udev->descriptor.idProduct));
usb_make_path(udev, usbtouch->phys, sizeof(usbtouch->phys));
- strlcpy(usbtouch->phys, "/input0", sizeof(usbtouch->phys));
+ strlcat(usbtouch->phys, "/input0", sizeof(usbtouch->phys));
input_dev->name = usbtouch->name;
input_dev->phys = usbtouch->phys;
--
1.5.2.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] [input] USB touchscreen
@ 2007-09-06 22:03 Vladimir Shebordaev
0 siblings, 0 replies; 5+ messages in thread
From: Vladimir Shebordaev @ 2007-09-06 22:03 UTC (permalink / raw)
To: linux-kernel; +Cc: Vladimir Shebordaev
From: Vladimir Shebordaev <vshebordaev@mail.ru>
This patch fixes a nasty typo in usbtouchscreen driver.
The typo is inherited from the original mtouchusb. It
used to make the input subsytem to incorrectly
report the physical device ids to userspace that in turn
is much confusing for, e.g. XInput hotplug facilities in
setups with multiple identical touchscreens.
Signed-off-by: Vladimir Shebordaev <vshebordaev@mail.ru>
---
drivers/input/touchscreen/usbtouchscreen.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c
index e3f2285..c32f447 100644
--- a/drivers/input/touchscreen/usbtouchscreen.c
+++ b/drivers/input/touchscreen/usbtouchscreen.c
@@ -734,7 +734,7 @@ static int usbtouch_probe(struct usb_interface *intf,
le16_to_cpu(udev->descriptor.idProduct));
usb_make_path(udev, usbtouch->phys, sizeof(usbtouch->phys));
- strlcpy(usbtouch->phys, "/input0", sizeof(usbtouch->phys));
+ strlcat(usbtouch->phys, "/input0", sizeof(usbtouch->phys));
input_dev->name = usbtouch->name;
input_dev->phys = usbtouch->phys;
--
1.5.2.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] [input] USB touchscreen
@ 2007-09-06 22:14 Vladimir Shebordaev
0 siblings, 0 replies; 5+ messages in thread
From: Vladimir Shebordaev @ 2007-09-06 22:14 UTC (permalink / raw)
To: linux-kernel; +Cc: Vladimir Shebordaev
From: Vladimir Shebordaev <vshebordaev@mail.ru>
This patch fixes a nasty typo in usbtouchscreen driver.
The typo is inherited from the original mtouchusb. It
used to make the input subsytem to incorrectly
report the physical device ids to userspace that in turn
is much confusing for, e.g. XInput hotplug facilities in
setups with multiple identical touchscreens.
Signed-off-by: Vladimir Shebordaev <vladimir.shebordaev@gmail.com>
---
drivers/input/touchscreen/usbtouchscreen.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c
index e3f2285..c32f447 100644
--- a/drivers/input/touchscreen/usbtouchscreen.c
+++ b/drivers/input/touchscreen/usbtouchscreen.c
@@ -734,7 +734,7 @@ static int usbtouch_probe(struct usb_interface *intf,
le16_to_cpu(udev->descriptor.idProduct));
usb_make_path(udev, usbtouch->phys, sizeof(usbtouch->phys));
- strlcpy(usbtouch->phys, "/input0", sizeof(usbtouch->phys));
+ strlcat(usbtouch->phys, "/input0", sizeof(usbtouch->phys));
input_dev->name = usbtouch->name;
input_dev->phys = usbtouch->phys;
--
1.5.2.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-09-07 1:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-06 21:29 [PATCH] [input] USB touchscreen Vladimir Shebordaev
2007-09-07 1:34 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2007-09-06 22:01 Vladimir Shebordaev
2007-09-06 22:03 Vladimir Shebordaev
2007-09-06 22:14 Vladimir Shebordaev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox