Re: [PATCH 0/3] build system: section garbage collection for vmlinux

Denys Vlasenko
2007-09-06T10:58:13Z

On Wednesday 05 September 2007 20:46, Daniel Walker wrote:
> On Wed, 2007-09-05 at 20:49 +0100, Denys Vlasenko wrote:
>
> > What does "it" stand for in this sentence?
>
> "it" is your patches, and I think we got to bottom of it .. "it" (i.e.
> your patches) don't actually work with modules, which is what you
> originally contended ..

Kernel builds, loads and runs with my patches, and modules load just fine.

> > My patch was tested to work in my limited testing,
> > but it is very conservative.
> >
> > I can't talk for Marcelo, but his patch probably worked too,
> > it just didn't guarantee that you can install kernel, and
> > then compile and load external module. Wel, it will compile,
> > but maybe will fail to load.
>
> At least you should modify your Kconfig changes so that you don't allow
> people to select your new option unless they have CONFIG_MODULES off..

You seem to have interesting definition of "desn't work".
--
vda