From: Christoph Hellwig <hch@infradead.org>
To: Valdis.Kletnieks@vt.edu
Cc: Theodore Tso <tytso@mit.edu>,
Randy Dunlap <randy.dunlap@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
mathieu.desnoyers@polymtl.ca, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/6] Linux Kernel Markers - Architecture Independent Code
Date: Fri, 7 Sep 2007 20:31:59 +0100 [thread overview]
Message-ID: <20070907193159.GA3023@infradead.org> (raw)
In-Reply-To: <6791.1189185054@turing-police.cc.vt.edu>
On Fri, Sep 07, 2007 at 01:10:54PM -0400, Valdis.Kletnieks@vt.edu wrote:
> Anybody got a proposed scheme for the case where somebody like myself
> who is *not* a member of the Maintainer Cabal has looked at a patch, and
> found a valid show-stopper that's bigger than just whitespace (breaks on
> 64-bit, locking issues, etc), or other commentary that *should* be addressed
> before it gets merged? I'd like *some* way to tag a patch with "I had an
> issue with V1, but the author addressed it to my satisfaction in V2"....
>
> (Note that includes "the author convinced me the patch was right and I was
> wrong"...)
I think that'd be Reviewed-By. While you are not part of the smokey room
cabal you have shown technical expertise in various areas so it seems
perfectly fine to have reviewed-by from you. The fix vs a previous version
should probably be just in the text with a paragraph ala:
Issue blah in a previous version as found by Valdis Kletnieks has been fixed
by doing foo.
next prev parent reply other threads:[~2007-09-07 19:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-06 20:07 [patch 0/6] Linux Kernel Markers for 2.6.23-rc4-mm1 Mathieu Desnoyers
2007-09-06 20:07 ` [patch 1/6] Linux Kernel Markers - Architecture Independent Code Mathieu Desnoyers
2007-09-06 23:00 ` Randy Dunlap
2007-09-06 23:04 ` Andrew Morton
2007-09-06 23:37 ` Randy Dunlap
2007-09-07 4:05 ` Valdis.Kletnieks
2007-09-07 4:11 ` Randy Dunlap
2007-09-07 16:04 ` Theodore Tso
2007-09-07 17:10 ` Valdis.Kletnieks
2007-09-07 19:31 ` Christoph Hellwig [this message]
2007-09-07 21:30 ` Roland Dreier
2007-09-07 13:01 ` Mathieu Desnoyers
2007-09-06 20:07 ` [patch 2/6] Linux Kernel Markers - Add kconfig menus for the marker code Mathieu Desnoyers
2007-09-06 23:35 ` Randy Dunlap
2007-09-12 14:54 ` Mathieu Desnoyers
2007-09-06 20:07 ` [patch 3/6] Linux Kernel Markers - Documentation Mathieu Desnoyers
2007-09-06 23:48 ` Randy Dunlap
2007-09-06 20:07 ` [patch 4/6] Linux Kernel Markers - Documentation Fix Mathieu Desnoyers
2007-09-06 20:07 ` [patch 5/6] Port of blktrace to the Linux Kernel Markers Mathieu Desnoyers
2007-09-06 20:07 ` [patch 6/6] Linux Kernel Markers - Port SPU to markers Mathieu Desnoyers
2007-09-08 7:04 ` Alexey Dobriyan
2007-09-08 7:23 ` Mathieu Desnoyers
2007-09-08 12:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070907193159.GA3023@infradead.org \
--to=hch@infradead.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=randy.dunlap@oracle.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox