Re: [patch 6/6] Linux Kernel Markers - Port SPU to markers

[Christoph Hellwig <hch@infradead.org>]

On Thu, Sep 06, 2007 at 04:07:39PM -0400, Mathieu Desnoyers wrote:
> Andrew, any chance to get this into -mm ASAP so we can have it in
> 2.6.24?
> 
> Just in case anyone wonders what this is usefulfor I've ported my
> hacking spu tracing code to it, and if markers get in I'd push a cleaned
> up version of this in the tree of the benefit of everyone trying to
> follow what's going on in the spufs code.  Similarly I'd like to port
> the xfs tracing code over to it which is very helpful in trying to
> debug filesystem issues.
> 
> Note that in this patch the actual logging code is rather nasty
> hand-crafted code lifted from the tcp probe in tree which would benefit
> of going away in favour of more general tracing code aswell.
> 
> Changelog:
> - Porting to 2.6.23-rc4-mm1 gave a reject (a trace point location disappeared)
>   from spufs_ps_nopfn() : spufs_ps_nopfn__sleep and spufs_ps_nopfn__wake.

The subject is rather confusing.  What I ported to markers is the spu _tracing_
support.  And given it's never been public before adding the port part to the
commit doesn't make much sense.

Nevermind, I have updated version of this and would prefer to submit it myself
through the spufs maintainer once markers make mainline (hopefully soon!)

I'll also need more cleanups like adding a config option for it.