public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Jean Delvare <khali@linux-fr.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	David Brownell <david-b@pacbell.net>
Subject: Re: Platform device id
Date: Sat, 8 Sep 2007 06:30:36 -0700	[thread overview]
Message-ID: <20070908133036.GA32145@suse.de> (raw)
In-Reply-To: <20070907153559.17faf9d1@hyperion.delvare>

On Fri, Sep 07, 2007 at 03:35:59PM +0200, Jean Delvare wrote:
> Hi Greg, all,
> 
> While platform_device.id is a u32, platform_device_add() handles "-1" as
> a special id value. This has potential for confusion and bugs. One such
> bug was reported to me by David Brownell:
> 
> http://lists.lm-sensors.org/pipermail/i2c/2007-September/001787.html
> 
> And since then I've found two other drivers  affected (uartlite and
> i2c-pxa).
> 
> Could we at least make platform_device.id an int so as to clear up the
> confusion? I doubt that the id will ever be a large number anyway.

Sure, that's fine by me, feel free to send a patch.

thanks,

greg k-h

  parent reply	other threads:[~2007-09-08 13:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-07 13:35 Platform device id Jean Delvare
2007-09-07 14:58 ` Dmitry Torokhov
2007-09-07 16:36   ` Jean Delvare
2007-09-07 16:41   ` David Brownell
2007-09-07 21:00     ` Henrique de Moraes Holschuh
2007-09-07 21:41       ` David Brownell
2007-09-07 22:04         ` Henrique de Moraes Holschuh
2007-09-08  0:18           ` David Brownell
2007-09-08  3:50             ` Henrique de Moraes Holschuh
2007-09-08  8:55               ` Jean Delvare
2007-09-10 22:52                 ` Henrique de Moraes Holschuh
2007-09-11  7:43                   ` Jean Delvare
2007-09-11 13:44                     ` Henrique de Moraes Holschuh
2007-09-11 14:05                       ` Jean Delvare
2007-09-07 20:56   ` Henrique de Moraes Holschuh
2007-09-08  8:40     ` Jean Delvare
2007-09-10 22:45       ` Henrique de Moraes Holschuh
2007-09-08 13:30 ` Greg KH [this message]
2007-09-09 10:54   ` [PATCH] Make platform_device.id an int Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070908133036.GA32145@suse.de \
    --to=gregkh@suse.de \
    --cc=david-b@pacbell.net \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox