From: Randy Dunlap <randy.dunlap@oracle.com>
To: "James C. Georgas" <jgeorgas@georgas.ca>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: broken ACPI NUMA config option
Date: Sat, 8 Sep 2007 22:00:43 -0700 [thread overview]
Message-ID: <20070908220043.8830512d.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1189309736.13467.77.camel@Tachyon.home>
On Sat, 08 Sep 2007 23:48:56 -0400 James C. Georgas wrote:
> On Sat, 2007-08-09 at 18:16 -0700, Randy Dunlap wrote:
>
> > 2.6.23-rc5-git1 builds for me when I follow those steps...
> > except for some Section mismatch warnings.
> >
>
> OK, it worked for me also, using torvalds/linux-2.6.git. The behaviour
> of the "select" directive in Kconfig appears to have changed since
> 2.6.22.6. It now turns on ACPI, even when PM is not selected.
>
> This still looks broken to me, because ACPI gets selected by ACPI_NUMA,
> and ACPI depends on PM, but PM is not selected. It works out in the end,
> as far as the build is concerned, but it still bugs me.
>
> Does anyone object to the idea of a selected item automatically
> selecting its own dependencies?
>
> For example, you would only need to specify one "select" directive in
> X86_64_ACPI_NUMA, (i.e. to turn on ACPI_NUMA). The configuration system
> would then recursively walk up ACPI_NUMA's dependency hierarchy, turning
> on what it needed.
That is highly desirable IMO. Not having that is one of the things
that makes using 'select' "evil."
Have you looked at the code and given any thought to implementing this?
Thanks,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-09-09 5:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-08 22:51 broken ACPI NUMA config option James C. Georgas
2007-09-08 22:54 ` James C. Georgas
2007-09-08 23:33 ` James C. Georgas
2007-09-09 1:09 ` Randy Dunlap
2007-09-09 1:16 ` Randy Dunlap
2007-09-09 3:48 ` James C. Georgas
2007-09-09 4:24 ` Yinghai Lu
2007-09-09 5:00 ` Randy Dunlap [this message]
2007-09-09 13:41 ` James C. Georgas
2007-09-09 17:32 ` Randy Dunlap
2007-09-09 1:22 ` James C. Georgas
2007-09-09 9:07 ` Andi Kleen
2007-09-09 13:19 ` [PATCH] KCONFIG: fix pseudo dependency between K8_NUMA and X86_64_ACPI_NUMA config options James C. Georgas
2007-09-09 13:46 ` Andi Kleen
2007-09-09 18:43 ` James C. Georgas
-- strict thread matches above, loose matches on Subject: below --
2007-09-09 2:36 broken ACPI NUMA config option James C. Georgas
2007-09-09 7:06 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070908220043.8830512d.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=jgeorgas@georgas.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox