From: Andi Kleen <andi@firstfloor.org>
To: "James C. Georgas" <jgeorgas@georgas.ca>
Cc: Andi Kleen <andi@firstfloor.org>,
Randy Dunlap <randy.dunlap@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KCONFIG: fix pseudo dependency between K8_NUMA and X86_64_ACPI_NUMA config options
Date: Sun, 9 Sep 2007 15:46:02 +0200 [thread overview]
Message-ID: <20070909134602.GA25798@one.firstfloor.org> (raw)
In-Reply-To: <1189343945.7365.9.camel@Tachyon.home>
On Sun, Sep 09, 2007 at 09:19:05AM -0400, James C. Georgas wrote:
> On Sun, 2007-09-09 at 11:07 +0200, Andi Kleen wrote:
> > "James C. Georgas" <jgeorgas@georgas.ca> writes:
> > >
> > > It's 2.6.22.6. I'm thinking a fix would be to add "select PM" to
> > > X86_64_ACPI_NUMA.
> > >
> > > I'm also thinking that maybe K8_NUMA should be changed from "depends on
> > > PCI" to "select PCI", like X86_64_ACPI_NUMA is. That would fix the
> > > pseudo dependency they have between them (i.e. selecting
> > > X86_64_ACPI_NUMA causes PCI to be selected, which then makes K8_NUMA
> > > visible, because its PCI dependency is now satisfied).
> >
> > Sounds reasonable. Can you please submit a tested patch with proper
> > description and Signed-off-by lines?
> >
> > -Andi
>
> How's this?
Thanks. How about a fix for the other problem (ACPI_NUMA- PM) too?
-Andi
next prev parent reply other threads:[~2007-09-09 13:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-08 22:51 broken ACPI NUMA config option James C. Georgas
2007-09-08 22:54 ` James C. Georgas
2007-09-08 23:33 ` James C. Georgas
2007-09-09 1:09 ` Randy Dunlap
2007-09-09 1:16 ` Randy Dunlap
2007-09-09 3:48 ` James C. Georgas
2007-09-09 4:24 ` Yinghai Lu
2007-09-09 5:00 ` Randy Dunlap
2007-09-09 13:41 ` James C. Georgas
2007-09-09 17:32 ` Randy Dunlap
2007-09-09 1:22 ` James C. Georgas
2007-09-09 9:07 ` Andi Kleen
2007-09-09 13:19 ` [PATCH] KCONFIG: fix pseudo dependency between K8_NUMA and X86_64_ACPI_NUMA config options James C. Georgas
2007-09-09 13:46 ` Andi Kleen [this message]
2007-09-09 18:43 ` James C. Georgas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070909134602.GA25798@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=jgeorgas@georgas.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox