From: Adrian Bunk <bunk@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Jiri Slaby <jirislaby@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] remove asm/bitops.h includes
Date: Sun, 9 Sep 2007 16:21:17 +0200 [thread overview]
Message-ID: <20070909142117.GH3563@stusta.de> (raw)
In-Reply-To: <p738x7gs1rq.fsf@bingen.suse.de>
On Sun, Sep 09, 2007 at 10:04:25AM +0200, Andi Kleen wrote:
> Jiri Slaby <jirislaby@gmail.com> writes:
>
> > remove asm/bitops.h includes
> >
> > including asm/bitops directly may cause compile errors.
>
> When does it cause compile errors? It would be probably less
> intrusive to just fix that case.
In -mm, include/asm-generic/bitops/non-atomic.h requires stuff from
include/linux/bitops.h
And it's generally better to have all users consistently use the linux/
headers instead of some using the linux/ headers and some the asm/
headers.
> -Andi
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2007-09-09 14:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-08 19:59 [PATCH 1/2] remove asm/bitops.h includes Jiri Slaby
2007-09-08 19:59 ` [PATCH 2/2] forbid asm/bitops.h direct inclusion Jiri Slaby
2007-09-10 12:28 ` Ralf Baechle
2007-09-10 13:03 ` Adrian Bunk
2007-09-09 8:04 ` [PATCH 1/2] remove asm/bitops.h includes Andi Kleen
2007-09-09 14:12 ` Jiri Slaby
2007-09-09 14:21 ` Adrian Bunk [this message]
2007-09-10 12:30 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070909142117.GH3563@stusta.de \
--to=bunk@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox