From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757743AbXIIOVT (ORCPT ); Sun, 9 Sep 2007 10:21:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756725AbXIIOVM (ORCPT ); Sun, 9 Sep 2007 10:21:12 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:46663 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756738AbXIIOVL (ORCPT ); Sun, 9 Sep 2007 10:21:11 -0400 Date: Sun, 9 Sep 2007 16:21:17 +0200 From: Adrian Bunk To: Andi Kleen Cc: Jiri Slaby , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] remove asm/bitops.h includes Message-ID: <20070909142117.GH3563@stusta.de> References: <30483262301654323266@pripojeni.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 09, 2007 at 10:04:25AM +0200, Andi Kleen wrote: > Jiri Slaby writes: > > > remove asm/bitops.h includes > > > > including asm/bitops directly may cause compile errors. > > When does it cause compile errors? It would be probably less > intrusive to just fix that case. In -mm, include/asm-generic/bitops/non-atomic.h requires stuff from include/linux/bitops.h And it's generally better to have all users consistently use the linux/ headers instead of some using the linux/ headers and some the asm/ headers. > -Andi cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed