From: Greg KH <greg@kroah.com>
To: Eric Lammerts <eric@lammerts.org>
Cc: linux-kernel@vger.kernel.org, p.hardwick@option.com,
akpm@linux-foundation.org
Subject: Re: [PATCH] nozomi DTR/RTS
Date: Sun, 9 Sep 2007 09:26:58 -0700 [thread overview]
Message-ID: <20070909162658.GA23411@kroah.com> (raw)
In-Reply-To: <46CEACC0.5000908@lammerts.org>
On Fri, Aug 24, 2007 at 12:02:40PM +0200, Eric Lammerts wrote:
> Hi,
> I noticed that DTR toggling doesn't work with the nozomi driver
> (TIOCMBIS/TIOCMBIC ioctls have no effect). This is a nuisance because that
> makes it hard to get the modem back in command mode.
>
> Attached patch adds a tty_ops->tiocmset function that makes it work.
>
> Should we also rip out the TIOCMBIS/TIOCMBIC handling in ntty_ioctl()? It
> doesn't seem to be used anyway.
>
> Patch is against 2.6.23-rc3-mm1, but not tested with that. I tested it with
> 2.6.18.4 and the pharscape.org driver.
Thanks, I've updated the driver in -mm with these changes.
greg k-h
prev parent reply other threads:[~2007-09-09 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-24 10:02 [PATCH] nozomi DTR/RTS Eric Lammerts
2007-08-24 10:45 ` Alan Cox
2007-09-09 16:26 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070909162658.GA23411@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=eric@lammerts.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.hardwick@option.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox