From: "Ken'ichi Ohmichi" <oomichi@mxs.nes.nec.co.jp>
To: Adrian Bunk <bunk@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Dan Aloni <da-x@monatomic.org>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [-mm patch] kernel/kexec.c: make code static
Date: Mon, 10 Sep 2007 11:55:49 +0900 [thread overview]
Message-ID: <20070910115549oomichi@mail.jp.nec.com> (raw)
In-Reply-To: <20070909202516.GQ3563@stusta.de>
Hi Adrian,
2007/09/09 22:25:16 +0200, Adrian Bunk <bunk@kernel.org> wrote:
>On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote:
>>...
>> Changes since 2.6.23-rc3-mm1:
>>...
>> +add-vmcoreinfo.patch
>>...
>> misc
>>...
>
>This patch makes the following needlessly global code static:
>- vmcoreinfo_data[]
>- vmcoreinfo_size
>- vmcoreinfo_append_str()
The kernel compiling fails with your patch because architecture-specific
function should access the above data/function:
# make
[snip]
arch/ia64/kernel/machine_kexec.c: In function 'arch_crash_save_vmcoreinfo':
arch/ia64/kernel/machine_kexec.c:134: error: implicit declaration of function 'SYMBOL'
arch/ia64/kernel/machine_kexec.c:135: error: implicit declaration of function 'LENGTH'
arch/ia64/kernel/machine_kexec.c:139: error: implicit declaration of function 'SIZE'
arch/ia64/kernel/machine_kexec.c:139: error: 'node_memblk_s' undeclared (first use in this function)
arch/ia64/kernel/machine_kexec.c:139: error: (Each undeclared identifier is reported only once
arch/ia64/kernel/machine_kexec.c:139: error: for each function it appears in.)
arch/ia64/kernel/machine_kexec.c:140: error: implicit declaration of function 'OFFSET'
arch/ia64/kernel/machine_kexec.c:140: error: 'start_paddr' undeclared (first use in this function)
arch/ia64/kernel/machine_kexec.c:141: error: 'size' undeclared (first use in this function)
arch/ia64/kernel/machine_kexec.c:144: error: implicit declaration of function 'CONFIG'
arch/ia64/kernel/machine_kexec.c:144: error: 'PGTABLE_3' undeclared (first use in this function)
make[1]: *** [arch/ia64/kernel/machine_kexec.o] Error 1
make: *** [arch/ia64/kernel] Error 2
#
Thanks
Ken'ichi Ohmichi
next prev parent reply other threads:[~2007-09-10 2:56 UTC|newest]
Thread overview: 153+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-01 4:58 2.6.23-rc4-mm1 Andrew Morton
2007-09-01 6:53 ` 2.6.23-rc4-mm1 KAMEZAWA Hiroyuki
2007-09-01 6:58 ` 2.6.23-rc4-mm1 Andrew Morton
2007-09-01 8:54 ` 2.6.23-rc4-mm1 Herbert Xu
2007-09-01 21:09 ` 2.6.23-rc4-mm1 Satyam Sharma
2007-09-02 1:46 ` 2.6.23-rc4-mm1 Herbert Xu
2007-09-02 2:52 ` 2.6.23-rc4-mm1 Satyam Sharma
2007-09-02 3:59 ` 2.6.23-rc4-mm1 Herbert Xu
2007-09-01 11:55 ` 2.6.23-rc4-mm1 Kamalesh Babulal
2007-09-01 14:18 ` 2.6.23-rc4-mm1: geode fb compile error Adrian Bunk
2007-09-01 17:03 ` Satyam Sharma
2007-09-01 15:19 ` 2.6.23-rc4-mm1: two ktime_sub_ns() functions Adrian Bunk
2007-09-01 15:44 ` 2.6.23-rc4-mm1: mips compile error Adrian Bunk
2007-09-04 5:27 ` Mathieu Desnoyers
2007-09-04 10:21 ` Ralf Baechle
2007-09-01 16:07 ` 2.6.23-rc4-mm1 Torsten Kaiser
2007-09-01 16:16 ` 2.6.23-rc4-mm1 Andrew Morton
2007-09-01 18:13 ` 2.6.23-rc4-mm1 OOPS in forcedeth? thunder7
2007-09-01 19:05 ` Jeff Garzik
2007-09-02 0:54 ` Satyam Sharma
2007-09-02 5:36 ` thunder7
2007-09-02 6:19 ` thunder7
2007-09-02 9:55 ` Satyam Sharma
2007-09-14 3:51 ` Andrew James Wade
2007-09-17 13:57 ` Dhaval Giani
2007-09-17 14:07 ` Denis V. Lunev
2007-09-17 21:00 ` Vlad Yasevich
2007-09-17 23:56 ` Satyam Sharma
2007-09-01 22:06 ` 2.6.23-rc4-mm1 "no CRC" MODPOST warnings Satyam Sharma
2007-09-01 22:40 ` Adrian Bunk
2007-09-01 23:15 ` Sam Ravnborg
2007-09-01 23:12 ` [PATCH -mm] softlockup-improve-debug-output.patch fix Satyam Sharma
2007-09-02 12:37 ` [PATCH -mm][resend] " Satyam Sharma
2007-09-02 12:28 ` Ingo Molnar
2007-09-06 6:52 ` [PATCH] sched: Use show_regs() to improve __schedule_bug() output Satyam Sharma
2007-10-22 12:35 ` Ingo Molnar
2007-09-03 16:36 ` [PATCH -mm][resend] softlockup-improve-debug-output.patch fix Valdis.Kletnieks
2007-09-01 23:42 ` [PATCH -mm] drivers/acpi/tables/tbutils.c: Shut up bogus uninitialized variable warning Satyam Sharma
2007-09-02 0:19 ` Adrian Bunk
2007-09-02 1:02 ` Satyam Sharma
2007-09-02 1:30 ` [PATCH -mm] net/sched/sch_cbq.c: Shut up " Satyam Sharma
2007-09-02 11:36 ` Patrick McHardy
2007-09-02 2:36 ` 2.6.23-rc4-mm1: unpingable box and NULL dereference at tcp_rto_min() Alexey Dobriyan
2007-09-02 5:02 ` Satyam Sharma
2007-09-02 20:52 ` Andrew Morton
2007-09-02 21:19 ` Alexey Dobriyan
2007-09-02 9:14 ` 2.6.23-rc4-mm1 net bitops compile error Adrian Bunk
2007-09-04 17:53 ` Jiri Slaby
2007-09-02 11:25 ` [-mm patch] IPV6 must select XFRM Adrian Bunk
2007-09-03 10:43 ` Masahide NAKAMURA
2007-09-06 10:01 ` net-26.24 broken with XFRM off Noriaki TAKAMIYA
2007-09-02 13:00 ` [PATCH -mm] drivers/char/nozomi.c: __devexit_p usage build fix Satyam Sharma
2007-09-02 19:01 ` 2.6.23-rc4-mm1: broke pata_via cable detection Laurent Riffard
2007-09-02 19:20 ` Alan Cox
2007-09-11 1:50 ` Jeff Garzik
2007-09-02 20:39 ` 2.6.23-rc4-mm1: boot failure on HPC nx6325 Rafael J. Wysocki
2007-09-03 8:36 ` Thomas Gleixner
2007-09-03 10:15 ` Rafael J. Wysocki
2007-09-03 20:51 ` Rafael J. Wysocki
2007-09-04 1:03 ` Thomas Gleixner
2007-09-03 4:30 ` 2.6.23-rc4-mm1 Randy Dunlap
2007-09-03 19:25 ` 2.6.23-rc4-mm1 Wim Van Sebroeck
2007-09-03 22:32 ` 2.6.23-rc4-mm1 Satyam Sharma
2007-09-04 21:21 ` 2.6.23-rc4-mm1 Wim Van Sebroeck
2007-09-04 17:54 ` 2.6.23-rc4-mm1 Zach Carter
2007-09-04 21:36 ` 2.6.23-rc4-mm1 Stephen Hemminger
2007-09-05 14:37 ` 2.6.23-rc4-mm1 Valdis.Kletnieks
2007-09-05 15:12 ` 2.6.23-rc4-mm1 Andrew Morton
2007-09-05 15:20 ` 2.6.23-rc4-mm1 Balbir Singh
2007-09-05 15:58 ` 2.6.23-rc4-mm1 Valdis.Kletnieks
2007-09-05 19:46 ` 2.6.23-rc4-mm1 - git-alsa.patch breaks audio on Dell Latitude D820 Valdis.Kletnieks
2007-09-05 19:54 ` Valdis.Kletnieks
2007-09-05 20:22 ` Takashi Iwai
2007-09-05 20:11 ` Takashi Iwai
2007-09-05 20:27 ` Takashi Iwai
2007-09-05 21:16 ` Valdis.Kletnieks
2007-09-05 21:39 ` Takashi Iwai
2007-09-06 14:10 ` Valdis.Kletnieks
2007-09-06 14:17 ` Takashi Iwai
2007-09-06 19:37 ` 2.6.23-rc4-mm1 myri10ge module link error on x86_64 Mathieu Desnoyers
2007-09-06 20:40 ` David Miller
2007-09-06 20:48 ` David Miller
2007-09-07 23:59 ` Jeff Garzik
2007-09-08 0:25 ` Daniel Walker
2007-10-13 22:03 ` Avuton Olrich
2007-09-09 12:22 ` 2.6.23-rc4-mm1 Mel Gorman
2007-09-14 15:12 ` ath5k driver not working on ThinkPad Robert de Rooy
2007-09-09 20:24 ` [-mm patch] alpha bitops.h must #include <asm/barrier.h> Adrian Bunk
2007-09-09 20:24 ` [-mm patch] remove ide_get_error_location() Adrian Bunk
2007-09-11 21:27 ` Bartlomiej Zolnierkiewicz
2007-09-12 5:54 ` Jens Axboe
2007-09-09 20:24 ` [-mm patch] drivers/dma/ioat_dma.c: make 3 functions static Adrian Bunk
2007-09-09 20:25 ` [-mm patch] usb/serial/ch341.c: make 4 " Adrian Bunk
2007-09-09 20:25 ` [-mm patch] make nfs_wb_page_priority() static Adrian Bunk
2007-09-09 20:25 ` [-mm patch] kernel/kexec.c: make code static Adrian Bunk
2007-09-10 2:55 ` Ken'ichi Ohmichi [this message]
2007-09-10 12:20 ` Adrian Bunk
2007-09-11 5:53 ` Maneesh Soni
2007-09-12 7:37 ` Ken'ichi Ohmichi
2007-09-09 20:25 ` [-mm patch] really unexport do_softirq Adrian Bunk
2007-09-12 13:14 ` David Miller
2007-09-09 20:25 ` [-mm patch] unexport raise_softirq_irqoff Adrian Bunk
2007-09-09 20:41 ` Christoph Hellwig
2007-09-12 13:15 ` David Miller
2007-09-09 20:25 ` [-mm patch] mm/memcontrol.c: clenups Adrian Bunk
2007-09-10 8:23 ` Balbir Singh
2007-09-10 19:58 ` Jan Engelhardt
2007-09-10 19:59 ` Jan Engelhardt
2007-09-10 21:59 ` Adrian Bunk
2007-09-11 2:41 ` Balbir Singh
2007-09-09 20:25 ` [-mm patch] net/sctp/socket.c: make 3 variables static Adrian Bunk
2007-09-10 14:05 ` [Lksctp-developers] " Neil Horman
2007-09-12 13:18 ` David Miller
2007-09-09 20:25 ` [-mm patch] make tcp_splice_data_recv() static Adrian Bunk
2007-09-12 13:21 ` David Miller
2007-09-12 17:44 ` Jens Axboe
2007-09-09 20:26 ` [-mm patch] make do_try_to_free_pages() static Adrian Bunk
2007-09-10 8:24 ` Balbir Singh
2007-09-10 17:43 ` 2.6.23-rc4-mm1 -- powerpc per_cpu__cpu_sibling_map compile failure Andy Whitcroft
2007-09-10 17:49 ` 2.6.23-rc4-mm1 Andy Whitcroft
2007-09-10 18:19 ` 2.6.23-rc4-mm1 Andrew Morton
2007-09-10 18:59 ` 2.6.23-rc4-mm1 Torsten Kaiser
2007-09-10 19:20 ` 2.6.23-rc4-mm1 Andrew Morton
2007-09-10 19:38 ` 2.6.23-rc4-mm1 Torsten Kaiser
2007-09-10 19:42 ` 2.6.23-rc4-mm1 FUJITA Tomonori
2007-09-10 20:43 ` 2.6.23-rc4-mm1 Torsten Kaiser
2007-09-11 8:32 ` 2.6.23-rc4-mm1 Jens Axboe
2007-09-10 19:10 ` 2.6.23-rc4-mm1 FUJITA Tomonori
2007-09-13 17:34 ` 2.6.23-rc4-mm1 Andy Whitcroft
2007-09-15 4:16 ` 2.6.23-rc4-mm1 Paul Jackson
2007-09-15 10:52 ` 2.6.23-rc4-mm1 FUJITA Tomonori
2007-09-17 13:28 ` 2.6.23-rc4-mm1 Jens Axboe
2007-09-17 14:32 ` 2.6.23-rc4-mm1 FUJITA Tomonori
2007-09-18 10:18 ` 2.6.23-rc4-mm1 Jens Axboe
2007-09-18 12:25 ` 2.6.23-rc4-mm1 FUJITA Tomonori
2007-09-18 12:51 ` 2.6.23-rc4-mm1 Jens Axboe
2007-09-10 19:31 ` 2.6.23-rc4-mm1 FUJITA Tomonori
2007-09-14 8:10 ` 2.6.23-rc4-mm1 Andy Whitcroft
2007-09-14 13:01 ` 2.6.23-rc4-mm1 Torsten Kaiser
2007-09-14 20:15 ` 2.6.23-rc4-mm1 Andrew Morton
2007-09-10 20:19 ` 2.6.23-rc4-mm1: git-block.patch broke pktcdvd Laurent Riffard
2007-09-13 22:50 ` Laurent Riffard
2007-09-13 23:05 ` Andrew Morton
2007-09-14 8:00 ` Jens Axboe
2007-09-14 8:30 ` Jens Axboe
2007-09-14 9:33 ` Jens Axboe
2007-09-14 11:06 ` Jens Axboe
2007-09-14 19:04 ` Laurent Riffard
2007-09-20 21:25 ` [PATCH] pktcdvd: don't rely on bio_init() preserving bio->bi_destructor Laurent Riffard
2007-09-21 5:19 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2007-09-06 7:25 net-26.24 broken with XFRM off Divy Le Ray
2007-09-06 8:13 ` Eric Dumazet
2007-09-06 9:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070910115549oomichi@mail.jp.nec.com \
--to=oomichi@mxs.nes.nec.co.jp \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=da-x@monatomic.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).