From: Adrian Bunk <bunk@kernel.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Jiri Slaby <jirislaby@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, rth@twiddle.net,
hskinnemoen@atmel.com, uclinux-dist-devel@blackfin.uclinux.org,
dev-etrax@axis.com, dhowells@redhat.com, discuss@x86-64.org,
linux-ia64@vger.kernel.org, linux-mips@linux-mips.org,
parisc-linux@parisc-linux.org, sparclinux@vger.kernel.org,
chris@zankel.net
Subject: Re: [PATCH 2/2] forbid asm/bitops.h direct inclusion
Date: Mon, 10 Sep 2007 15:03:52 +0200 [thread overview]
Message-ID: <20070910130352.GF3563@stusta.de> (raw)
In-Reply-To: <20070910122838.GA10143@linux-mips.org>
On Mon, Sep 10, 2007 at 01:28:38PM +0100, Ralf Baechle wrote:
> On Sat, Sep 08, 2007 at 09:00:48PM +0100, Jiri Slaby wrote:
>
> > forbid asm/bitops.h direct inclusion
> >
> > Because of compile errors that may occur after bit changes if asm/bitops.h is
> > included directly without e.g. linux/kernel.h which includes linux/bitops.h, forbid
> > direct inclusion of asm/bitops.h. Thanks to Adrian Bunk.
>
> This is the kind of thing that checkpatch.pl is already checking for and
> I like that idea much more than adding thousands of checks over many of
> the header files under asm.
Checks in the header are only for header files where including only the
asm header doesn't work which doesn't seem to be the common case.
> Ralf
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2007-09-10 13:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-08 19:59 [PATCH 1/2] remove asm/bitops.h includes Jiri Slaby
2007-09-08 19:59 ` [PATCH 2/2] forbid asm/bitops.h direct inclusion Jiri Slaby
2007-09-10 12:28 ` Ralf Baechle
2007-09-10 13:03 ` Adrian Bunk [this message]
2007-09-09 8:04 ` [PATCH 1/2] remove asm/bitops.h includes Andi Kleen
2007-09-09 14:12 ` Jiri Slaby
2007-09-09 14:21 ` Adrian Bunk
2007-09-10 12:30 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070910130352.GF3563@stusta.de \
--to=bunk@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chris@zankel.net \
--cc=dev-etrax@axis.com \
--cc=dhowells@redhat.com \
--cc=discuss@x86-64.org \
--cc=hskinnemoen@atmel.com \
--cc=jirislaby@gmail.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=parisc-linux@parisc-linux.org \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
--cc=sparclinux@vger.kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox