From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759974AbXIJND5 (ORCPT ); Mon, 10 Sep 2007 09:03:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758360AbXIJNDr (ORCPT ); Mon, 10 Sep 2007 09:03:47 -0400 Received: from mailout.stusta.mhn.de ([141.84.69.5]:60689 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758089AbXIJNDq (ORCPT ); Mon, 10 Sep 2007 09:03:46 -0400 Date: Mon, 10 Sep 2007 15:03:52 +0200 From: Adrian Bunk To: Ralf Baechle Cc: Jiri Slaby , Andrew Morton , linux-kernel@vger.kernel.org, rth@twiddle.net, hskinnemoen@atmel.com, uclinux-dist-devel@blackfin.uclinux.org, dev-etrax@axis.com, dhowells@redhat.com, discuss@x86-64.org, linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, parisc-linux@parisc-linux.org, sparclinux@vger.kernel.org, chris@zankel.net Subject: Re: [PATCH 2/2] forbid asm/bitops.h direct inclusion Message-ID: <20070910130352.GF3563@stusta.de> References: <30483262301654323266@pripojeni.net> <276116173913632310@pripojeni.net> <20070910122838.GA10143@linux-mips.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20070910122838.GA10143@linux-mips.org> User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 10, 2007 at 01:28:38PM +0100, Ralf Baechle wrote: > On Sat, Sep 08, 2007 at 09:00:48PM +0100, Jiri Slaby wrote: > > > forbid asm/bitops.h direct inclusion > > > > Because of compile errors that may occur after bit changes if asm/bitops.h is > > included directly without e.g. linux/kernel.h which includes linux/bitops.h, forbid > > direct inclusion of asm/bitops.h. Thanks to Adrian Bunk. > > This is the kind of thing that checkpatch.pl is already checking for and > I like that idea much more than adding thousands of checks over many of > the header files under asm. Checks in the header are only for header files where including only the asm header doesn't work which doesn't seem to be the common case. > Ralf cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed