public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: linuxsh-dev@lists.sourceforge.net
Cc: "Adrian McMenamin" <lkmladrian@gmail.com>,
	"Paul Mundt" <lethal@linux-sh.org>,
	linux-kernel@vger.kernel.org,
	Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH 1/2] Maple Bus support for SEGA Dreamcast
Date: Mon, 10 Sep 2007 19:28:47 -0400	[thread overview]
Message-ID: <200709101928.48719.vapier@gentoo.org> (raw)
In-Reply-To: <8b67d60709101616p7430a572w3ed0921a846805@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

On Monday 10 September 2007, Adrian McMenamin wrote:
> +config MAPLE
> +	tristate "Maple Bus Support"
> +	depends on SH_DREAMCAST
> +	help
> +	  The Maple Bus is SEGA's serial communication bus for peripherals
> +	  on the Dreamcast. Without this bus support you won't be able to
> +	  get your Dreamcast keyboard etc to work, so most users
> +	  probably want to say 'Y' here, unless you are only using the
> +	  Dreamcast with a serial line terminal or a remote network
> +	  connection.

hmm, tristate means you can build it as a module ... so please add a line that 
says what the module name is if 'M' is selected ...

> --- a/drivers/sh/Makefile
> +++ b/drivers/sh/Makefile
> +obj-$(CONFIG_MAPLE) += maple/

ok ...

> --- /dev/null
> +++ b/drivers/sh/maple/Makefile
> +obj-y	:= maplebus.o

erp, shouldnt that be obj-$(CONFIG_MAPLE) ?
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

  reply	other threads:[~2007-09-10 23:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-10 23:16 [PATCH 1/2] Maple Bus support for SEGA Dreamcast Adrian McMenamin
2007-09-10 23:28 ` Mike Frysinger [this message]
2007-09-11  4:27 ` Paul Mundt
2007-09-11  6:13   ` Greg KH
2007-09-11  6:39   ` Adrian McMenamin
2007-09-11  6:57     ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200709101928.48719.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=arjan@infradead.org \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxsh-dev@lists.sourceforge.net \
    --cc=lkmladrian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox