The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Zhenyu Wang <zhenyu.z.wang@intel.com>
Cc: Dave Airlie <airlied@linux.ie>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [AGPGART] intel_agp: fix GTT map size on G33
Date: Mon, 10 Sep 2007 22:15:02 -0700	[thread overview]
Message-ID: <20070910221502.dba1d5ce.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070905071307.GB5817@zhen-devel.sh.intel.com>

On Wed, 5 Sep 2007 15:13:07 +0800 Zhenyu Wang <zhenyu.z.wang@intel.com> wrote:

> 
> Subject: [PATCH] [AGPGART] intel_agp: fix GTT map size on G33
> 
> G33 has 1MB GTT table range. Fix GTT mapping
> in case like 512MB aperture size.
> 
> Signed-off-by: Zhenyu Wang <zhenyu.z.wang@intel.com>
> ---
>  drivers/char/agp/intel-agp.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
> index 20d50d0..6a5c555 100644
> --- a/drivers/char/agp/intel-agp.c
> +++ b/drivers/char/agp/intel-agp.c
> @@ -919,6 +919,7 @@ static int intel_i915_create_gatt_table(struct agp_bridge_data *bridge)
>  	struct aper_size_info_fixed *size;
>  	int num_entries;
>  	u32 temp, temp2;
> +	int gtt_map_size = 256 * 1024;
>  
>  	size = agp_bridge->current_size;
>  	page_order = size->page_order;
> @@ -928,7 +929,9 @@ static int intel_i915_create_gatt_table(struct agp_bridge_data *bridge)
>  	pci_read_config_dword(intel_private.pcidev, I915_MMADDR, &temp);
>  	pci_read_config_dword(intel_private.pcidev, I915_PTEADDR,&temp2);
>  
> -	intel_private.gtt = ioremap(temp2, 256 * 1024);
> +	if (IS_G33)
> +	    gtt_map_size = 1024 * 1024; /* 1M on G33 */
> +	intel_private.gtt = ioremap(temp2, gtt_map_size);
>  	if (!intel_private.gtt)
>  		return -ENOMEM;
>  

Ditto.  What happens if this patch isn't in 2.6.23?  And is it applicable to
and needed in 2.6.22?

  reply	other threads:[~2007-09-11  5:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-05  7:13 [PATCH] [AGPGART] intel_agp: fix GTT map size on G33 Zhenyu Wang
2007-09-11  5:15 ` Andrew Morton [this message]
2007-09-11  8:09   ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070910221502.dba1d5ce.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=airlied@linux.ie \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhenyu.z.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox