From: Andi Kleen <ak@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
kbuild devel <kbuild-devel@lists.sourceforge.net>
Subject: Re: [RFC] kbuild - introduce vdir to make life easier for x86_64
Date: Tue, 11 Sep 2007 00:40:41 +0200 [thread overview]
Message-ID: <200709110040.41605.ak@suse.de> (raw)
In-Reply-To: <20070910191138.GA31541@uranus.ravnborg.org>
> The below are the minimal clean-up - a bit more could be done.
>
> Comments?
Looks good in principle. My only suggestion would be to name it something
differently than vdir. I know that's what GNU make calls it, but it's still
pretty cryptic. How about just fallback-dir ?
Also what would be nice (I don't know if it's doable in make) would
be a separate variable (e.g. other-obj-... := ) that contains the fallback
names and that is double checked against the fallback directory. That
would document it clearly what's going on. Failing that stuffing
them into a comment would be good at least.
-Andi
next prev parent reply other threads:[~2007-09-10 22:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-10 19:11 [RFC] kbuild - introduce vdir to make life easier for x86_64 Sam Ravnborg
2007-09-10 19:22 ` Thomas Gleixner
2007-09-10 19:29 ` Ingo Molnar
2007-09-10 20:34 ` Sam Ravnborg
2007-09-10 20:44 ` Thomas Gleixner
2007-09-10 22:40 ` Andi Kleen [this message]
2007-09-10 22:50 ` H. Peter Anvin
2007-09-11 6:49 ` Sam Ravnborg
2007-09-11 19:42 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709110040.41605.ak@suse.de \
--to=ak@suse.de \
--cc=kbuild-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox