public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Andi Kleen <ak@suse.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	kbuild devel <kbuild-devel@lists.sourceforge.net>
Subject: Re: [RFC] kbuild - introduce vdir to make life easier for x86_64
Date: Tue, 11 Sep 2007 08:49:42 +0200	[thread overview]
Message-ID: <20070911064942.GA3663@uranus.ravnborg.org> (raw)
In-Reply-To: <200709110040.41605.ak@suse.de>

On Tue, Sep 11, 2007 at 12:40:41AM +0200, Andi Kleen wrote:
> 
> > The below are the minimal clean-up - a bit more could be done.
> > 
> > Comments?
> 
> Looks good in principle. My only suggestion would be to name it something
> differently than vdir. I know that's what GNU make calls it, but it's still
> pretty cryptic. How about just fallback-dir ? 
fallback-dir is better.
vdir came from make's vpath but then very few knows about vpath anyway so that 
was not the best source of inspiration.

 
> Also what would be nice (I don't know if it's doable in make) would
> be a separate variable (e.g. other-obj-... := ) that contains the fallback
> names and that is double checked against the fallback directory.
My first attempt was along these lines but I dropped it for two reasons:
1) Mixing obj-y and other-obj-y assinment broke all assumptions on linkorder.
   It would not be possible to link objexts in order a1.o, a2.o, a3.o if a1.o
   and a3.o were assigned to obj-y and a2.o was assigned to other-obj-y. 

2) It needed a decent amouth of unreadable gmake-foo to introduce
   a second variable. And the learning curve for kbuild internals are alreay
   to steep so I try to avoid additional complexity.

I'm a bit reluctant to just enable the fallback-dir functionality.
There is no point in adding this for the sake of x86 if we merge
i386 and x86_64 a few days after.

	Sam

  parent reply	other threads:[~2007-09-11  6:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-10 19:11 [RFC] kbuild - introduce vdir to make life easier for x86_64 Sam Ravnborg
2007-09-10 19:22 ` Thomas Gleixner
2007-09-10 19:29   ` Ingo Molnar
2007-09-10 20:34     ` Sam Ravnborg
2007-09-10 20:44       ` Thomas Gleixner
2007-09-10 22:40 ` Andi Kleen
2007-09-10 22:50   ` H. Peter Anvin
2007-09-11  6:49   ` Sam Ravnborg [this message]
2007-09-11 19:42   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070911064942.GA3663@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=ak@suse.de \
    --cc=kbuild-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox