From: Nigel Cunningham <nigel@nigel.suspend2.net>
To: LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Rafael Wysocki <rjw@sisk.pl>
Subject: [PATCH] Fix failure to resume from initrds.
Date: Tue, 11 Sep 2007 13:54:24 +1000 [thread overview]
Message-ID: <200709111354.25689.nigel@nigel.suspend2.net> (raw)
Hi all.
Commit 831441862956fffa17b9801db37e6ea1650b0f69 (Freezer: make kernel threads
nonfreezable by default) breaks freezing when attempting to resume from an
initrd, because the init (which is freezeable) spins while waiting for another
thread to run /linuxrc, but doesn't check whether it has been told to enter
the refrigerator. The original patch replaced a call to try_to_freeze() with a
call to yield(). I believe a simple reversion is wrong because
if !CONFIG_PM_SLEEP, try_to_freeze() is a noop. It should still yield.
Signed-off-by: Nigel Cunningham <nigel@nigel.suspend2.net>
do_mounts_initrd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -ruNp 952-fix-initrd-resume.patch-old/init/do_mounts_initrd.c 952-fix-initrd-resume.patch-new/init/do_mounts_initrd.c
--- 952-fix-initrd-resume.patch-old/init/do_mounts_initrd.c 2007-09-11 13:43:31.000000000 +1000
+++ 952-fix-initrd-resume.patch-new/init/do_mounts_initrd.c 2007-09-11 13:19:50.000000000 +1000
@@ -58,8 +58,10 @@ static void __init handle_initrd(void)
pid = kernel_thread(do_linuxrc, "/linuxrc", SIGCHLD);
if (pid > 0)
- while (pid != sys_wait4(-1, NULL, 0, NULL))
+ while (pid != sys_wait4(-1, NULL, 0, NULL)) {
yield();
+ try_to_freeze();
+ }
if (!resume_attempted)
printk(KERN_ERR "Suspend2: No attempt was made to resume from "
--
See http://www.tuxonice.net for Howtos, FAQs, mailing
lists, wiki and bugzilla info.
next reply other threads:[~2007-09-11 3:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 3:54 Nigel Cunningham [this message]
2007-09-11 11:04 ` [PATCH] Fix failure to resume from initrds Rafael J. Wysocki
2007-09-11 11:27 ` Nigel Cunningham
2007-09-11 11:55 ` Rafael J. Wysocki
2007-09-11 13:01 ` Nigel Cunningham
2007-09-11 13:12 ` Rafael J. Wysocki
2007-09-11 13:23 ` Rafael J. Wysocki
2007-09-11 13:41 ` Nigel Cunningham
2007-09-11 19:25 ` Rafael J. Wysocki
2007-09-11 14:39 ` Linus Torvalds
2007-09-11 16:27 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2007-09-14 12:22 Rafael J. Wysocki
2007-09-14 12:20 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709111354.25689.nigel@nigel.suspend2.net \
--to=nigel@nigel.suspend2.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nigel@suspend2.net \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox