From: Adrian Bunk <bunk@kernel.org>
To: Andi Kleen <ak@suse.de>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: x86 merge - a little feedback
Date: Tue, 11 Sep 2007 23:51:40 +0200 [thread overview]
Message-ID: <20070911215140.GV3563@stusta.de> (raw)
In-Reply-To: <200709112234.24155.ak@suse.de>
On Tue, Sep 11, 2007 at 10:34:23PM +0100, Andi Kleen wrote:
>
> >
> > People do not expect code under arch/i386/ to be used by code under
> > arch/x86_64/ and vice versa.
> >
> > That regularly results in people sending patches that don't compile on
> > the other architecture.
> >
> > With one architecture it's much more obvious that the code is shared.
>
> Will that cause people to compile test both? I have my doubts that
> will really work.
>...
You will see that it could be shared, and it'll be much easier to see
all configurations it's used in.
Currently, there are 6 or 7 different ways how a function under
arch/i386/ could be used by a function under arch/x86_64/ (and vice
versa) and it's non-trivial to figure out all usages when grep'ing for
users.
> -Andi
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2007-09-11 21:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 20:12 x86 merge - a little feedback Sam Ravnborg
2007-09-11 20:25 ` Thomas Gleixner
2007-09-11 21:24 ` Linus Torvalds
2007-09-11 20:34 ` Adrian Bunk
2007-09-11 21:05 ` Sam Ravnborg
2007-09-11 21:09 ` Adrian Bunk
2007-09-12 9:27 ` Christoph Hellwig
2007-09-12 12:45 ` Lennart Sorensen
2007-09-11 20:38 ` Andi Kleen
2007-09-11 21:14 ` Adrian Bunk
2007-09-11 21:34 ` Andi Kleen
2007-09-11 21:51 ` Linus Torvalds
2007-09-12 18:14 ` Jan Engelhardt
2007-09-11 21:51 ` Adrian Bunk [this message]
2007-09-12 0:29 ` Paul Mundt
2007-09-15 10:55 ` Andrew Morton
2007-09-15 9:32 ` Andrew Morton
2007-09-15 18:36 ` Andi Kleen
2007-09-16 5:08 ` Andrew Morton
2007-09-11 21:21 ` Linus Torvalds
2007-09-12 19:09 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070911215140.GV3563@stusta.de \
--to=bunk@kernel.org \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox