From: Paul Mundt <lethal@linux-sh.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Michael Buesch <mb@bu3sch.de>, linux-kernel@vger.kernel.org
Subject: [PATCH -mm] ssb: Make pcmciahost depend on PCMCIA=y
Date: Wed, 12 Sep 2007 11:11:00 +0900 [thread overview]
Message-ID: <20070912021100.GB26827@linux-sh.org> (raw)
SSB uses a bool (SSB_PCMCIAHOST_POSSIBLE) to determine whether to
build in PCMCIA support or not, as the PCMCIA host code itself is
also only a bool, make SSB_PCMCIAHOST_POSSIBLE depend on PCMCIA=y.
Without this, SSB_PCMCIAHOST_POSSIBLE evaluates to y when PCMCIA
is built as a module, which results in link errors due to the
pcmcia_access_configuration_register() accesses, where the symbol
is only defined in a module.
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
--
drivers/ssb/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.23-rc4-mm1.orig/drivers/ssb/Kconfig 2007-09-11 15:15:52.000000000 +0900
+++ linux-2.6.23-rc4-mm1/drivers/ssb/Kconfig 2007-09-12 10:51:53.000000000 +0900
@@ -37,7 +37,7 @@
config SSB_PCMCIAHOST_POSSIBLE
bool
- depends on SSB && PCMCIA && EXPERIMENTAL
+ depends on SSB && PCMCIA=y && EXPERIMENTAL
default y
config SSB_PCMCIAHOST
next reply other threads:[~2007-09-12 2:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-12 2:11 Paul Mundt [this message]
2007-09-12 10:09 ` [PATCH -mm] ssb: Make pcmciahost depend on PCMCIA=y Michael Buesch
2007-09-12 10:17 ` Paul Mundt
2007-09-12 10:59 ` Michael Buesch
2007-09-13 1:43 ` Paul Mundt
2007-09-20 19:42 ` Joseph Fannin
2007-09-20 20:33 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070912021100.GB26827@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox